From 9c83cf74f4dc7b7b9d4d8a20dc0b62e13a83a5b4 Mon Sep 17 00:00:00 2001 From: Dominik Jain Date: Sun, 27 Jul 2025 11:00:40 +0200 Subject: [PATCH] Further improve logging of dependency installation --- src/solidlsp/language_servers/common.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/solidlsp/language_servers/common.py b/src/solidlsp/language_servers/common.py index 58a1f1b9..4ce8f3b4 100644 --- a/src/solidlsp/language_servers/common.py +++ b/src/solidlsp/language_servers/common.py @@ -80,7 +80,7 @@ class RuntimeDependencyCollection: kwargs["user"] = pwd.getpwuid(os.getuid()).pw_name log.info("Running command '%s' in '%s'", command, cwd) - completed_proces = subprocess.run( + completed_process = subprocess.run( command, shell=True, check=True, @@ -89,11 +89,13 @@ class RuntimeDependencyCollection: stderr=subprocess.STDOUT, **kwargs, ) - log.log( - logging.WARNING if completed_proces.returncode else logging.INFO, - "Command completed with return code %d", - completed_proces.returncode, - ) + if completed_process.returncode != 0: + log.warning("Command '%s' failed with return code %d", command, completed_process.returncode) + log.warning("Command output:\n%s", completed_process.stdout) + else: + log.info( + "Command completed successfully", + ) @staticmethod def _install_from_url(dep: RuntimeDependency, logger: LanguageServerLogger, target_dir: str) -> None: