From c972380d0a11c291c874b6c68a4b6ddb3eea1ff2 Mon Sep 17 00:00:00 2001 From: takeokunn Date: Sun, 8 Feb 2026 01:03:12 +0900 Subject: [PATCH] fix(test): remove php_phpactor symlink and add repo alias mapping Remove the unnecessary php_phpactor -> php symlink. Instead, add a _LANGUAGE_REPO_ALIASES mapping in conftest.py so that variant language servers (PHP_PHPACTOR, PYTHON_JEDI, RUBY_SOLARGRAPH) resolve to their base language's test repository without needing filesystem symlinks. Addresses review comment on PR #1002. --- test/conftest.py | 10 +++++++++- test/resources/repos/php_phpactor | 1 - 2 files changed, 9 insertions(+), 2 deletions(-) delete mode 120000 test/resources/repos/php_phpactor diff --git a/test/conftest.py b/test/conftest.py index e02b428c..74dff913 100644 --- a/test/conftest.py +++ b/test/conftest.py @@ -34,8 +34,16 @@ class LanguageParamRequest: param: Language +_LANGUAGE_REPO_ALIASES: dict[Language, Language] = { + Language.PHP_PHPACTOR: Language.PHP, + Language.PYTHON_JEDI: Language.PYTHON, + Language.RUBY_SOLARGRAPH: Language.RUBY, +} + + def get_repo_path(language: Language) -> Path: - return Path(__file__).parent / "resources" / "repos" / language / "test_repo" + repo_language = _LANGUAGE_REPO_ALIASES.get(language, language) + return Path(__file__).parent / "resources" / "repos" / repo_language / "test_repo" def _create_ls( diff --git a/test/resources/repos/php_phpactor b/test/resources/repos/php_phpactor deleted file mode 120000 index fa557ad9..00000000 --- a/test/resources/repos/php_phpactor +++ /dev/null @@ -1 +0,0 @@ -php \ No newline at end of file