Refactoring: Rename Language to LanguageServerId

This resolves a long-standing naming issue in Serena & SolidLSP.
This commit is contained in:
Dominik Jain authored and Dominik Jain committed 2026-07-22 20:55:36 +02:00
1 parent ef0e218fb1
commit d2cf18ddcb
180 files changed
+1806 -1767

No files matched your search

+10 -10
View File
@@ -9,7 +9,7 @@ import pytest
from serena.symbol import LanguageServerSymbol
from solidlsp import SolidLanguageServer
from solidlsp.ls_config import Language
from solidlsp.ls_config import LanguageServerId
from solidlsp.ls_types import SymbolKind
from test.solidlsp.conftest import format_symbol_for_assert, has_malformed_name, request_all_symbols
@@ -18,13 +18,13 @@ from test.solidlsp.conftest import format_symbol_for_assert, has_malformed_name,
class TestMarkdownLanguageServerBasics:
"""Test basic functionality of the markdown language server."""
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_language_server_initialization(self, language_server: SolidLanguageServer) -> None:
"""Test that markdown language server can be initialized successfully."""
assert language_server is not None
assert language_server.language == Language.MARKDOWN
assert language_server.ls_id == LanguageServerId.MARKDOWN
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_request_document_symbols(self, language_server: SolidLanguageServer) -> None:
"""Test request_document_symbols for markdown files."""
all_symbols, _root_symbols = language_server.request_document_symbols("README.md").get_all_symbols_and_roots()
@@ -40,7 +40,7 @@ class TestMarkdownLanguageServerBasics:
f"Heading '{symbol['name']}' should have kind Namespace, got {SymbolKind(symbol['kind']).name}"
)
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_request_symbols_from_guide(self, language_server: SolidLanguageServer) -> None:
"""Test symbol detection in guide.md file."""
all_symbols, _root_symbols = language_server.request_document_symbols("guide.md").get_all_symbols_and_roots()
@@ -48,7 +48,7 @@ class TestMarkdownLanguageServerBasics:
# At least some headings should be found
assert len(all_symbols) > 0, f"Should find headings in guide.md, found {len(all_symbols)}"
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_request_symbols_from_api(self, language_server: SolidLanguageServer) -> None:
"""Test symbol detection in api.md file."""
all_symbols, _root_symbols = language_server.request_document_symbols("api.md").get_all_symbols_and_roots()
@@ -56,7 +56,7 @@ class TestMarkdownLanguageServerBasics:
# Should detect headings from api.md
assert len(all_symbols) > 0, f"Should find headings in api.md, found {len(all_symbols)}"
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_request_document_symbols_with_body(self, language_server: SolidLanguageServer) -> None:
"""Test request_document_symbols with body extraction."""
all_symbols, _root_symbols = language_server.request_document_symbols("README.md").get_all_symbols_and_roots()
@@ -68,7 +68,7 @@ class TestMarkdownLanguageServerBasics:
# This test is more lenient and just verifies the API works
assert all_symbols is not None, "Should return symbols even if body extraction is limited"
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_headings_not_low_level(self, language_server: SolidLanguageServer) -> None:
"""Test that markdown headings are not classified as low-level symbols.
@@ -84,7 +84,7 @@ class TestMarkdownLanguageServerBasics:
f"Heading '{symbol['name']}' should not be low-level (kind={SymbolKind(symbol['kind']).name})"
)
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_markdown_nested_headings_remapped(self, language_server: SolidLanguageServer) -> None:
"""Test that nested headings (h1-h5) are all remapped from String to Namespace."""
all_symbols, _root_symbols = language_server.request_document_symbols("api.md").get_all_symbols_and_roots()
@@ -95,7 +95,7 @@ class TestMarkdownLanguageServerBasics:
for symbol in all_symbols:
assert symbol["kind"] == SymbolKind.Namespace, f"Nested heading '{symbol['name']}' should be remapped to Namespace"
@pytest.mark.parametrize("language_server", [Language.MARKDOWN], indirect=True)
@pytest.mark.parametrize("language_server", [LanguageServerId.MARKDOWN], indirect=True)
def test_bare_symbol_names(self, language_server) -> None:
all_symbols = request_all_symbols(language_server)
malformed_symbols = []