From 6b0ec584971aad7dfee167018b0624eb2aca8516 Mon Sep 17 00:00:00 2001 From: "tomasz.kowalczewski" Date: Sat, 16 Jan 2021 20:47:18 +0100 Subject: [PATCH] Re #7: Added default value to maxRequestsInFlight, and check in the builder if it is > 0 (or else exception is thrown). --- .../java/pl/tkowalcz/tjahzi/log4j2/LokiAppenderBuilder.java | 2 +- .../pl/tkowalcz/tjahzi/http/ClientConfigurationBuilder.java | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/loki-log4j2-appender/src/main/java/pl/tkowalcz/tjahzi/log4j2/LokiAppenderBuilder.java b/loki-log4j2-appender/src/main/java/pl/tkowalcz/tjahzi/log4j2/LokiAppenderBuilder.java index 51f0876..f58ff39 100644 --- a/loki-log4j2-appender/src/main/java/pl/tkowalcz/tjahzi/log4j2/LokiAppenderBuilder.java +++ b/loki-log4j2-appender/src/main/java/pl/tkowalcz/tjahzi/log4j2/LokiAppenderBuilder.java @@ -58,7 +58,7 @@ public class LokiAppenderBuilder> extends Abstr private String logLevelLabel; @PluginBuilderAttribute - private int maxRequestsInFlight; + private int maxRequestsInFlight = 100; @PluginElement("Headers") private Header[] headers; diff --git a/tjahzi-core/src/main/java/pl/tkowalcz/tjahzi/http/ClientConfigurationBuilder.java b/tjahzi-core/src/main/java/pl/tkowalcz/tjahzi/http/ClientConfigurationBuilder.java index 38ac480..d0ebc19 100644 --- a/tjahzi-core/src/main/java/pl/tkowalcz/tjahzi/http/ClientConfigurationBuilder.java +++ b/tjahzi-core/src/main/java/pl/tkowalcz/tjahzi/http/ClientConfigurationBuilder.java @@ -7,7 +7,7 @@ public class ClientConfigurationBuilder { public static final int DEFAULT_CONNECT_TIMEOUT_MILLIS = 5_000; public static final int DEFAULT_REQUEST_TIMEOUT_MILLIS = 60_000; - public static final int DEFAULT_MAX_REQUESTS_IN_FLIGHT = 10; + public static final int DEFAULT_MAX_REQUESTS_IN_FLIGHT = 100; public static final int DEFAULT_MAX_RETRIES = 0; @@ -57,6 +57,10 @@ public class ClientConfigurationBuilder { } public ClientConfiguration build() { + if (maxRequestsInFlight <= 0) { + throw new IllegalArgumentException("Property maxRequestsInFlight must be greater than 0"); + } + return new ClientConfiguration( logEndpoint, host,