diff --git a/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializer.java b/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializer.java index 3e69dad..46dc394 100644 --- a/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializer.java +++ b/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializer.java @@ -47,11 +47,14 @@ public class LabelSerializer { cursor - lastSizePosition - Integer.BYTES); } - public void appendLabel(String key, String value) { + public LabelSerializer appendLabel(String key, String value) { appendLabelName(key); + startAppendingLabelValue(); appendPartialLabelValue(value); finishAppendingLabelValue(); + + return this; } public DirectBuffer getBuffer() { diff --git a/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializers.java b/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializers.java index abb9cc6..d8e57ea 100644 --- a/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializers.java +++ b/core/src/main/java/pl/tkowalcz/tjahzi/LabelSerializers.java @@ -1,7 +1,5 @@ package pl.tkowalcz.tjahzi; -import java.util.Map; - public class LabelSerializers { private static final ThreadLocal THREAD_LOCAL = ThreadLocal.withInitial(LabelSerializer::new); @@ -12,27 +10,4 @@ public class LabelSerializers { return result; } - - // @VisibleForTests - public static LabelSerializer from(Map labels, String... moreLabels) { - LabelSerializer labelSerializer = threadLocal(); - - labels.forEach(labelSerializer::appendLabel); - for (int i = 0; i < moreLabels.length; i += 2) { - labelSerializer.appendLabel(moreLabels[i], moreLabels[i + 1]); - } - - return labelSerializer; - } - - // @VisibleForTests - public static LabelSerializer from(String... labels) { - LabelSerializer labelSerializer = threadLocal(); - - for (int i = 0; i < labels.length; i += 2) { - labelSerializer.appendLabel(labels[i], labels[i + 1]); - } - - return labelSerializer; - } } diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/HeadersTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/HeadersTest.java index e1bfed2..dc5146b 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/HeadersTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/HeadersTest.java @@ -41,7 +41,7 @@ class HeadersTest { initializer = new TjahziInitializer(); monitoringModule = new StandardMonitoringModule(); - labelSerializer = LabelSerializers.from("level", "warn"); + labelSerializer = LabelSerializerCreator.from("level", "warn"); } @AfterEach diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LabelSerializerCreator.java b/core/src/test/java/pl/tkowalcz/tjahzi/LabelSerializerCreator.java new file mode 100644 index 0000000..82b732f --- /dev/null +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LabelSerializerCreator.java @@ -0,0 +1,27 @@ +package pl.tkowalcz.tjahzi; + +import java.util.Map; + +class LabelSerializerCreator { + + public static LabelSerializer from(Map labels, String... moreLabels) { + LabelSerializer labelSerializer = LabelSerializers.threadLocal(); + + labels.forEach(labelSerializer::appendLabel); + for (int i = 0; i < moreLabels.length; i += 2) { + labelSerializer.appendLabel(moreLabels[i], moreLabels[i + 1]); + } + + return labelSerializer; + } + + public static LabelSerializer from(String... labels) { + LabelSerializer labelSerializer = LabelSerializers.threadLocal(); + + for (int i = 0; i < labels.length; i += 2) { + labelSerializer.appendLabel(labels[i], labels[i + 1]); + } + + return labelSerializer; + } +} diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferAgentTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferAgentTest.java index 40d85b6..f7b9f89 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferAgentTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferAgentTest.java @@ -55,7 +55,7 @@ class LogBufferAgentTest { for (int i = 0; i < 100; i++) { logger.log( 42L, - LabelSerializers.from(Map.of()), + LabelSerializerCreator.from(Map.of()), ByteBuffer.wrap(( "Cupcake ipsum dolor sit amet cake wafer. " + "Soufflé jelly beans biscuit topping. " + @@ -95,7 +95,7 @@ class LogBufferAgentTest { logger.log( 42L, - LabelSerializers.from(Map.of()), + LabelSerializerCreator.from(Map.of()), ByteBuffer.wrap("Test".getBytes()) ); @@ -164,7 +164,7 @@ class LogBufferAgentTest { // When logger.log( 42L, - LabelSerializers.from(Map.of()), + LabelSerializerCreator.from(Map.of()), ByteBuffer.wrap("Test".getBytes()) ); clock.tick(wait5s + 1); @@ -172,7 +172,7 @@ class LogBufferAgentTest { logger.log( 42L, - LabelSerializers.from(Map.of()), + LabelSerializerCreator.from(Map.of()), ByteBuffer.wrap("Test".getBytes()) ); clock.tick(wait5s + 1); diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerDeserializerTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerDeserializerTest.java index bd2cb7b..44c76f5 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerDeserializerTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerDeserializerTest.java @@ -84,7 +84,7 @@ class LogBufferSerializerDeserializerTest { UnsafeBuffer buffer = new UnsafeBuffer(ByteBuffer.wrap(new byte[expectedSize])); LogBufferSerializer serializer = new LogBufferSerializer(buffer); - LabelSerializer labelSerializer = LabelSerializers.from(labels); + LabelSerializer labelSerializer = LabelSerializerCreator.from(labels); if (logLevelLabel != null) { labelSerializer.appendLabel(logLevelLabel, logLevel); } diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerTest.java index 408e4bc..31fe667 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferSerializerTest.java @@ -24,7 +24,7 @@ class LogBufferSerializerTest { UnsafeBuffer buffer = new UnsafeBuffer(new byte[expectedSize]); LogBufferSerializer serializer = new LogBufferSerializer(buffer); - LabelSerializer labelSerializer = LabelSerializers.from(labels); + LabelSerializer labelSerializer = LabelSerializerCreator.from(labels); if (logLevelLabel != null) { labelSerializer.appendLabel(logLevelLabel, logLevel); } diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferTranscoderTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferTranscoderTest.java index b783fe3..a9fd2e6 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferTranscoderTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LogBufferTranscoderTest.java @@ -40,7 +40,7 @@ class LogBufferTranscoderTest { ); LogBufferSerializer serializer = new LogBufferSerializer(buffer); - LabelSerializer labelSerializer = LabelSerializers.from(labels); + LabelSerializer labelSerializer = LabelSerializerCreator.from(labels); if (logLevelLabel != null) { labelSerializer.appendLabel(logLevelLabel, logLevel); } @@ -115,7 +115,7 @@ class LogBufferTranscoderTest { UnsafeBuffer buffer = new UnsafeBuffer(ByteBuffer.wrap(new byte[256])); LogBufferSerializer serializer = new LogBufferSerializer(buffer); - LabelSerializer labelSerializer = LabelSerializers.from(incomingLabels); + LabelSerializer labelSerializer = LabelSerializerCreator.from(incomingLabels); labelSerializer.appendLabelName("log_level"); labelSerializer.appendLabelName("WARN"); diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemSanityCheckTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemSanityCheckTest.java index 1003941..2405000 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemSanityCheckTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemSanityCheckTest.java @@ -89,7 +89,7 @@ class LoggingSystemSanityCheckTest { long timestamp = System.currentTimeMillis(); TjahziLogger logger = loggingSystem.createLogger(); - LabelSerializer labelSerializer = LabelSerializers.from("level", "warn"); + LabelSerializer labelSerializer = LabelSerializerCreator.from("level", "warn"); // When logger.log( diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemTest.java index bebbb5b..040c223 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/LoggingSystemTest.java @@ -97,7 +97,7 @@ class LoggingSystemTest { for (int i = 0; i < 1000; i++) { logger.log( timestamp + i, - LabelSerializers.from( + LabelSerializerCreator.from( Map.of("level", "warn") ), ByteBuffer.wrap(("Test" + i).getBytes()) diff --git a/core/src/test/java/pl/tkowalcz/tjahzi/ReconnectTest.java b/core/src/test/java/pl/tkowalcz/tjahzi/ReconnectTest.java index 9cae026..f582568 100644 --- a/core/src/test/java/pl/tkowalcz/tjahzi/ReconnectTest.java +++ b/core/src/test/java/pl/tkowalcz/tjahzi/ReconnectTest.java @@ -44,7 +44,7 @@ public class ReconnectTest { initializer = new TjahziInitializer(); monitoringModule = new StandardMonitoringModule(); - labelSerializer = LabelSerializers.from("level", "warn"); + labelSerializer = LabelSerializerCreator.from("level", "warn"); } @AfterEach diff --git a/log4j2-appender/src/test/java/pl/tkowalcz/tjahzi/log4j2/AppenderLogicTest.java b/log4j2-appender/src/test/java/pl/tkowalcz/tjahzi/log4j2/AppenderLogicTest.java index 1f10e4f..cefdc9a 100644 --- a/log4j2-appender/src/test/java/pl/tkowalcz/tjahzi/log4j2/AppenderLogicTest.java +++ b/log4j2-appender/src/test/java/pl/tkowalcz/tjahzi/log4j2/AppenderLogicTest.java @@ -42,7 +42,8 @@ class AppenderLogicTest { logEvent.setTimeMillis(timestamp); logEvent.setContextData(new JdkMapAdapterStringMap(Map.of())); - LabelSerializer labelSerializer = LabelSerializers.from(logLevelLabel, "INFO"); + LabelSerializer labelSerializer = LabelSerializers.threadLocal() + .appendLabel(logLevelLabel, "INFO"); // When logic.accept(logEvent, ByteBuffer.allocate(1024)); @@ -98,7 +99,8 @@ class AppenderLogicTest { logEvent.setTimeMillis(timestamp); logEvent.setContextData(new JdkMapAdapterStringMap(contextMap)); - LabelSerializer labelSerializer = LabelSerializers.from(logLevelLabel, "INFO"); + LabelSerializer labelSerializer = LabelSerializers.threadLocal() + .appendLabel(logLevelLabel, "INFO"); // When logic.accept(logEvent, ByteBuffer.allocate(1024));