mirror of
https://github.com/tiennm99/DocsGPT.git
synced 2026-10-13 16:14:10 +00:00
fix: better error logging
This commit is contained in:
1 parent
a9068faefa
commit
057b510adf
2 files changed
+20
-3
No files matched your search
@@ -5,6 +5,7 @@ import math
|
||||
|
||||
from flask import current_app, jsonify, make_response, redirect, request
|
||||
from flask_restx import fields, Namespace, Resource
|
||||
from pydantic import ValidationError
|
||||
|
||||
from application.api import api
|
||||
from application.api.user.tasks import reingest_source_task, sync_source
|
||||
@@ -573,11 +574,20 @@ class SourceConfigResource(Resource):
|
||||
jsonify({"success": False, "message": "Invalid config body"}), 400
|
||||
)
|
||||
# Strict validation (D7 strict-on-write): reject invalid config → 400.
|
||||
# Return a static message (no exception text) so validation internals
|
||||
# aren't exposed to the caller; the client validates the same rules
|
||||
# before submitting.
|
||||
try:
|
||||
new_config = SourceConfig.model_validate(body)
|
||||
except Exception as err:
|
||||
except ValidationError:
|
||||
return make_response(
|
||||
jsonify({"success": False, "message": f"Invalid config: {err}"}), 400
|
||||
jsonify(
|
||||
{
|
||||
"success": False,
|
||||
"message": "Invalid config: one or more fields failed validation.",
|
||||
}
|
||||
),
|
||||
400,
|
||||
)
|
||||
|
||||
try:
|
||||
|
||||
@@ -287,7 +287,14 @@ class Dispatcher(BaseRetriever):
|
||||
try:
|
||||
group_docs = retriever.search(query) if query else retriever.search()
|
||||
except Exception as exc:
|
||||
logger.error("Group '%s' search failed: %s", group["retriever"], exc)
|
||||
# Log the exception type only — a raw exception message can
|
||||
# carry the vector-store DSN (with credentials) on connection
|
||||
# errors.
|
||||
logger.error(
|
||||
"Group '%s' search failed: %s",
|
||||
group["retriever"],
|
||||
type(exc).__name__,
|
||||
)
|
||||
continue
|
||||
context = {"query": query, "retriever": group["retriever"]}
|
||||
group_docs = self._run_stages(
|
||||
|
||||
Reference in new issue
Block a user