fix(browser): make Lightpanda backend usable end-to-end

Live testing surfaced three issues:

- Lightpanda numbers targets per-browser, and each conn is its own
  browser, so every tab gets the same upstream targetID
  ("FID-0000000001"). Synthesize globally-unique "lp-N" keys for our
  internal map so multi-tenant tab tracking works.
- page.Info() returns valid data once post-open then errors on
  subsequent calls, which made ListTabs silently drop tabs. Cache URL
  and Title at OpenTab time and read from the cache in ListTabs.
- rod.Browser.Close() calls Browser.close which Lightpanda doesn't
  implement; the WS drops cleanly anyway. Swallow the error to quiet
  the noisy log line.

Two Lightpanda upstream bugs are documented in docs/browser-backends.md
and exercised by TestLightpanda_KnownUpstreamGaps:
  1. Accessibility.getFullAXTree returns nodeId as a JSON number
     (CDP spec: string)
  2. Runtime.evaluate rejects go-rod's function-apply wrapper
This commit is contained in:
Pierre Tachoire committed 2026-07-01 10:23:20 +02:00
1 parent 890ced810d
commit 4147fee4e5
4 files changed
+81 -21

No files matched your search

+9 -5
View File
@@ -39,6 +39,7 @@ type Manager struct {
refs *RefStore
pages map[string]*rod.Page // targetID → page
pageConns map[string]*rod.Browser // lightpanda only: targetID → dedicated CDP conn
pageInfos map[string]TabInfo // lightpanda only: cached URL/Title (page.Info() is unreliable upstream)
console map[string][]ConsoleMessage // targetID → console messages
tenantCtxs map[string]*rod.Browser // chrome only: browser scope key → incognito browser context
pageTenants map[string]string // targetID → browser scope key (for filtering)
@@ -53,6 +54,7 @@ type Manager struct {
cookieProvider CookieProvider
stopReaper chan struct{} // signal to stop the reaper goroutine
logger *slog.Logger
nextLpTabSeq uint64 // lightpanda only: monotonic counter for synthetic tab IDs
}
// Option configures a Manager.
@@ -107,6 +109,7 @@ func New(opts ...Option) *Manager {
refs: NewRefStore(),
pages: make(map[string]*rod.Page),
pageConns: make(map[string]*rod.Browser),
pageInfos: make(map[string]TabInfo),
console: make(map[string][]ConsoleMessage),
tenantCtxs: make(map[string]*rod.Browser),
pageTenants: make(map[string]string),
@@ -154,6 +157,7 @@ func (m *Manager) isRunningLocked() bool {
func (m *Manager) resetPageMapsLocked() {
m.pages = make(map[string]*rod.Page)
m.pageConns = make(map[string]*rod.Browser)
m.pageInfos = make(map[string]TabInfo)
m.console = make(map[string][]ConsoleMessage)
m.pageTenants = make(map[string]string)
m.pageLastUsed = make(map[string]time.Time)
@@ -336,12 +340,12 @@ func (m *Manager) Stop(ctx context.Context) error {
}
// Lightpanda: close every per-tab connection. Lightpanda auto-cleans the
// browser on disconnect, so no page.Close() is required.
// browser on disconnect, so no page.Close() is required. rod.Browser.Close
// calls Browser.close which Lightpanda doesn't implement (UnknownMethod);
// the WS drops regardless, so swallow the error.
if m.backend == BackendLightpanda {
for tid, conn := range m.pageConns {
if err := conn.Close(); err != nil {
m.logger.Warn("lightpanda: failed to close page conn", "targetId", tid, "error", err)
}
for _, conn := range m.pageConns {
_ = conn.Close()
}
m.cdpURL = ""
m.resetPageMapsLocked()