Commit Graph
928 Commits
Author SHA1 Message Date
viettranx b663d92fa4 fix(cron): skip loadClaimedJob for manual runs
Allow manual job runs even when job is disabled by checking job ID before
claiming. Prevents skipping manually triggered executions.
2026-04-02 08:23:07 +07:00
viettranx c48639369b fix(cron): apply timezone to all schedule kinds, not just cron
Move TZ application before schedule kind switch in MergeCronSchedule.
Ensure timezone applies consistently to cron, every, and at expressions.
2026-04-02 08:23:05 +07:00
viettranx 7d5c670708 feat(channels): add thread support to all channel handlers
Pass threadID and threadType to EnsureContact across all channel integrations:
- Discord, Feishu, Slack, Telegram, WhatsApp, Zalo
- Include General topic in contact collection
2026-04-02 08:23:03 +07:00
viettranx ac3af93df5 feat(contacts): implement thread_id persistence in PG and SQLite stores
- Update UpsertContact to handle threadID and threadType
- Strip username from sender_id compound key
- Implement in both PostgreSQL and SQLite backends
2026-04-02 08:23:01 +07:00
viettranx bf98a32e9b feat(store): add thread support to contact model and collector
- Add threadID and threadType to ContactCollector.EnsureContact
- Update ContactStore.UpsertContact signature
- Update Contact type in web UI
2026-04-02 08:22:57 +07:00
viettranx 670000651d feat(sqlite): add thread_id columns to contacts schema
Update SQLite schema to include thread_id and thread_type columns.
2026-04-02 08:22:54 +07:00
viettranx 5d632a522e feat(db): add migration 35 for contact thread_id columns
Add thread_id, thread_type columns to track forum topics and threaded conversations.
2026-04-02 08:22:53 +07:00
viettranx 28aa667c77 refactor(cron): redesigned run history with cleaner layout + status icons
- StatusIcon component with CheckCircle2/XCircle for visual feedback
- Compact timeline layout: icon, timestamp, duration badge, summary, tokens, status
- Error messages in monospace <pre> blocks with error-specific styling
- Mobile: duration + tokens move to expanded section
- Hide pagination when single page
2026-04-01 23:24:48 +07:00
viettranx cac3974e7c feat(cron): delivery UI with Select dropdowns + targets fetching
- Replace free-text Input with Select for Channel + To fields
- Fetch delivery targets via HEARTBEAT_TARGETS RPC
- Populate To options based on selected Channel
- Fallback to Input when no targets available
2026-04-01 23:24:44 +07:00
viettranx 4a0d938452 fix(ui): combobox dropdown auto-focus only on user interaction
- Check relatedTarget and document.hasFocus() to distinguish user-initiated focus
- Prevent programmatic focus from opening dropdown unintentionally
2026-04-01 23:24:40 +07:00
viettranx 523b084478 fix(telegram): retry pairing message without thread ID on hidden topic
- Handle 'thread not found' error when forum General topic is hidden/deleted
- Retry without messageThreadID for graceful fallback to main chat
2026-04-01 23:24:38 +07:00
viettranx 2f97d58c83 feat(heartbeat): support topic suffix in delivery targets
- Use array_to_string([5:]) in PG to capture full chatId with topic:N suffix
- Add extractSessionKeyTail() for SQLite forum group support
- Join on base chatId for contact display name resolution
2026-04-01 23:24:36 +07:00
viettranx 8ba4bd7c4a fix(cron): RunJob NULL-safe comparison and timezone persistence
- Use IS DISTINCT FROM instead of != for NULL handling in RunJob claim
- Always apply patch TZ (empty = UTC default). Callers send full schedule
2026-04-01 23:24:33 +07:00
viettranx 04dc34e32c fix(schema): exempt multi-action tools from OpenAI strict mode
Strict mode forces ALL properties to be required, causing models to
send ~13 empty params per tool call on multi-action tools like
team_tasks (17 actions, 16 params). This wastes ~200-300 output tokens
per call.

- Add IsMultiActionSchema() to detect tools with action+enum pattern
- Per-tool strict decision in CleanToolSchemas (exempt multi-action)
- Extract normalizeWithProfile() for per-tool profile overrides
- Add per-action param guide to team_tasks description
- Fix schema/impl mismatches: file_id→path, add task_type property
- Gate param guide on policy (lite edition only sees allowed actions)
2026-04-01 22:00:05 +07:00
viettranx 43232c6189 fix(heartbeat): clarify HEARTBEAT_OK decision criteria to suppress "no news" responses
Model was delivering formatted "nothing new" status updates instead of using
HEARTBEAT_OK because instructions were ambiguous about what "nothing to deliver"
means. Now explicitly states: "A no news summary is NOT worth delivering."
2026-04-01 21:16:44 +07:00
viettranx da240a5e09 fix: pool validation false positive + OAuth step advancement + pool routing sync (#583, #594)
- Skip disabled providers in pool graph validation to prevent false
  "member already exists" errors when stale pool configs linger (#583)
- Add retry logic (3 attempts, 1s delay) in setup wizard OAuth flow
  to handle backend commit race condition (#594)
- Reset chatgpt_oauth_routing in agent other_config when provider
  changes, with amber warning in UI (#583)
- Add 3 pool validation tests for disabled provider scenarios
- Add providerChangedWarning i18n key (en/vi/zh)
2026-04-01 19:31:02 +07:00
MK d334a2082f fix(pg): align SearchByEmbedding SQL placeholders with scope args (#623) 2026-04-01 18:28:56 +07:00
viettranx d819e08071 fix(security): fix media upload permission denied + symlink protection
- Fix workspace dir ownership in Docker entrypoint: chown dirs not owned
  by goclaw on startup (handles dirs created by root in previous lifecycle)
- Add symlink check on .uploads/ via os.Lstat before file creation to
  prevent symlink-based attacks replacing .uploads with link to sensitive dir
2026-04-01 18:11:42 +07:00
Huy Doan 41c827c65f fix(agent): update setAgentStatus to include tenantID parameter (#621)
Summoning failures (e.g. provider timeout) left agents stuck in summoning because failure paths called setAgentStatus(context.Background(), ...) without tenant scope, causing agent not found on update. Pass tenantID to setAgentStatus and re-attach tenant context when missing.
2026-04-01 18:07:43 +07:00
viettranx 1b190fa0bb fix(prompt): reduce mechanical chat behavior + optimize system prompt
- Add Tool Call Style section with narration minimalism + non-disclosure
  rule (from TS reference): agents must never expose tool names to users
- Consolidate 3 redundant memory recall reminders into 1 dedicated section
- Remove "tell the user you checked but found nothing" instruction that
  caused agents to describe internal tool mechanics in responses
- Remove 11 tool aliases from system prompt listing (~300 tokens saved);
  aliases still work via provider definitions
- Filter alias tool names out of system prompt ToolNames in loop_history
- Update AGENTS.md: remove tool name references from Memory section,
  add group chat framing from V1 ("participant, not their proxy")
2026-04-01 16:27:41 +07:00
viettranx c388364d2c fix(ui): fix chat streaming race condition + require agent selection + improve chat UX
- Fix race condition where session-change effect cleared runIdRef after
  run.started already captured it, causing chunk events to be filtered
  out (user saw "thinking" but no streamed tokens on new chats)
- Add SessionRunID to router + return runId in session status response
  as backup restoration for event filtering
- Require explicit agent selection before chat input is shown
- Redesign ChatInput: attach icon inside input container, aligned send
- Port desktop UX: wobble animation for tool calls, auto-expand thinking
  block on stream start, amber icon for streaming, iteration step count
2026-04-01 16:12:44 +07:00
Plateau Nguyen 066c61f09a fix(ui): improve event detail dialog layout and scroll behavior (#619)
* fix(ui): improve event detail dialog layout and scroll behavior

* fix(ui): apply review suggestions for event detail dialog
2026-04-01 15:26:15 +07:00
Viet Tran 52c67d6d92 feat(build): embed web UI in backend binary + simplify Docker variants (#620)
- Add internal/webui/ package with //go:build embedui tag for optional
  SPA embedding (handler.go serves static files with SPA fallback)
- Add internal/version/ shared semver comparison (DRY: extracted from
  gateway/update_check.go and updater/updater.go)
- Enhance UpdateChecker: release notes, ETag caching, filter lite-v* tags
- Add web UI build stage to Dockerfile with ENABLE_EMBEDUI build arg
- Simplify CI: 7 Docker variants → 4 (base, latest, full, otel)
- Add SHA256 checksums job to release workflow
- Add Makefile build-full target (embeds web UI in Go binary)
- Default make up now embeds web UI (no separate nginx needed)
- Add WITH_WEB_NGINX=1 flag for optional nginx reverse proxy
- Update README + 30 translated READMEs: make up, port 18790
- Update docker-compose comments and prepare-env.sh
- About dialog: show release notes with markdown rendering
- Health card: amber badge for available updates

BREAKING: Default Docker setup no longer requires selfservice overlay.
Web dashboard served at :18790 (same port as API).
2026-04-01 15:25:59 +07:00
viettranx 39bb90bd60 refactor(permissions): remove auto-add file writer, add config type constants
- Remove auto-add logic that granted file_writer permission to the first
  group/guild member who chatted with the bot
- Add ConfigTypeFileWriter and ConfigTypeHeartbeat constants, replace all
  hardcoded config_type strings across callers
- Add bootstrap exception: /addwriter and !addwriter allow first writer
  to be added when no writers exist yet
- Optimize writer commands: reuse cached ListFileWriters result for both
  permission check and last-writer guard, reducing DB queries per command
- Add freshness directive to file writer system prompt so bot prioritizes
  current list over stale references in conversation history
2026-04-01 13:59:56 +07:00
viettranx f4369c51e4 fix(providers): make provider_type immutable + add argString tests
Prevent SSRF bypass via provider_type change on update — ACP skips URL
validation, so changing type post-creation could circumvent the check.
Add table-driven unit tests for argString() covering all JSON type
coercion paths (float64, int, NaN, json.Number, nil).
2026-04-01 11:59:21 +07:00
Huy Doan 238d639de7 fix(providers): skip URL validation for ACP provider api_base (#610)
* fix(providers): skip URL validation for ACP provider api_base

ACP uses api_base to store agent command/binary, so enforcing http/https URL validation rejects valid ACP configs. Bypass provider URL checks for ACP while keeping URL validation for HTTP-based providers.

* fix(message): enhance target handling in message tool to support numeric chat IDs

- Introduced argString function to correctly parse numeric chat IDs from tool arguments, ensuring they are treated as strings when necessary.
- Added a new test case to verify that numeric targets are correctly processed and sent via the Telegram channel.
2026-04-01 11:55:48 +07:00
Duc Nguyen 983f6184d9 fix(ui): dynamic searchable timezone picker with validation (#614)
Replace hardcoded 20-entry IANA_TIMEZONES with getAllIanaTimezones()
using Intl.supportedValuesOf (~400 zones). Switch Select dropdowns
to searchable Combobox in cron, heartbeat, and system config.

Add defense-in-depth timezone validation:
- Backend: validate in heartbeat.set handler and SetDefaultTimezone()
- Frontend: isValidIanaTimezone() guard before save in all 3 dialogs

Closes #614
2026-04-01 11:12:35 +07:00
viettranx 9c2b4cbf0f fix(agent): improve memory recall accuracy and flush safety
- Add "low confidence" instruction to memory_search tool description
  to prevent models from fabricating memories when no results found
- Add dedicated ## Memory Recall section in system prompt (supplements
  recency reminder) with clear instructions for memory_search/memory_get
- Update flush prompts: replace YYYY-MM-DD with actual date at runtime,
  cleaner append-only wording
- Update AGENTS.md memory privacy section for multi-tenant: remove
  implementation details (per-user scoping), keep group chat output
  guardrails that work for both shared and isolated memory configs
2026-04-01 09:16:16 +07:00
viettranx 5b66d64545 fix(ui): decouple Edit with AI from SummoningModal, improve agent create UX
- RegenerateDialog now handles its own progress via WS events instead of
  opening SummoningModal (inline spinner + auto-close on completion)
- Clean up SummoningModal: remove mode/isRegenerate prop, summon-only
- Agent create: default to Predefined, collapse Open type behind toggle
  with warning banner explaining per-user context trade-off
- Add 4 new agent presets: Coder, Support, Writer, Translator (en/vi/zh)
- Remove 15 dead summoning.regenerate* i18n keys
2026-04-01 09:06:41 +07:00
viettranx 2092c50a04 fix(agent): use DB provider_type for SOUL echo and strict mode detection
- Add providerTypeOf() to extract provider_type via type assertion
  (e.g. "chatgpt_oauth") instead of config name (user-set "openai")
- Exclude "compat" providers (openai_compat → OpenRouter/DeepSeek/Groq)
  from strict mode and SOUL echo — they proxy to non-OpenAI models
- Fix isOpenAIStrict matching openai_compat incorrectly
2026-03-31 23:38:48 +07:00
viettranx 2a9400949b fix(agent): SOUL echo in recency zone for OpenAI/Codex providers
GPT models have strong recency bias and lose persona in long prompts.
Extract Style/Vibe sections from SOUL.md and echo them at the end of
the system prompt (~200 chars each) so GPT sees personality traits right
before generating. Only applies to OpenAI/Codex — Claude respects early
system prompt instructions well and doesn't need this.
2026-03-31 23:32:21 +07:00
viettranx ff4d370d27 fix(mcp): require 3 consecutive ping failures before marking server disconnected
Single transient errors (e.g. 504 from upstream proxy) no longer
instantly disconnect MCP servers. Requires healthFailThreshold (3)
consecutive failures before setting connected=false and triggering
reconnect. Applies to both Manager.healthLoop and poolHealthLoop.
2026-03-31 23:15:59 +07:00
viettranx e48ba1df7f fix(mcp): prevent LLM hallucination of optional tool parameters
3-layer defense against GPT-5.4 filling all optional MCP tool params
with fabricated values (e.g. api_key:"optional", proxyUrl:"http://example.com"):

Layer 1 — bridge_tool.go: expand placeholder detection to catch "optional",
"skip", example URLs; type-aware empty string handling (keep for string-typed,
strip for non-string); add propertyType() helper.

Layer 2 — schema_strict.go: OpenAI strict mode transform — optional props
become nullable unions, all props required, additionalProperties:false.
Constrained decoding prevents invalid output. Only enabled for first-party
OpenAI/Codex providers.

Layer 3 — systemprompt_sections.go: concrete WRONG/RIGHT examples in MCP
optional param instruction.
2026-03-31 23:15:59 +07:00
Tai Nguyen 06de8b41cf fix(cmd): sanitize followup reminder UTF-8 truncation (#609)
Prevent invalid UTF-8 from being persisted when auto-setting followups by sanitizing message content and truncating by rune count. Add regression tests for emoji truncation and malformed byte sequences.
2026-03-31 23:14:39 +07:00
viettranx f623ef9d55 feat(mcp): hybrid search mode — keep first 40 tools inline, defer rest
Instead of all-or-nothing when MCP tool count exceeds threshold,
keep first 40 tools registered inline and only defer the excess
to BM25 search via mcp_tool_search. System prompt now shows both
inline descriptions and search guidance in hybrid mode.

Also raises skill inline count from 40 to 60 (token limit is the
real bottleneck for skills).
2026-03-31 23:14:12 +07:00
viettranx aaa56ff004 fix(ui): summoning modal mode, dialog widths, and MCP refresh animation
- Add mode prop to SummoningModal (summon vs regenerate) so Edit with AI
  shows appropriate text instead of summoning language
- Fix memory document and KG entity detail dialogs using sm:max-w-* to
  properly override base sm:max-w-lg from DialogContent
- Expose isFetching from useMCP hook so refresh button animation works
2026-03-31 23:07:15 +07:00
viettranx ef0de0d760 fix(kg): merge recursive CTE branches and widen detail dialog
Combine forward+reverse traversal into single recursive branch using
CASE to fix SQLSTATE 42P19 (PostgreSQL parses triple UNION ALL as
left-associative, putting recursive ref in non-recursive term).

Also widen entity detail dialog from max-w-5xl to max-w-7xl.
2026-03-31 19:33:01 +07:00
viettranx 1d39626a88 fix(agent): use forward-scan replaceFirstMediaTag for correct multi-ref ordering
Replace replaceLastMediaTag with replaceFirstMediaTag across all 5 media
enrichment functions. Forward iteration + first-match produces natural
positional pairing, fixing reversed tag alignment when multiple media
refs exist in one message.

Also fixes same latent bug in enrichDocumentPaths, enrichAudioIDs, and
enrichVideoIDs. Supersedes #608.
2026-03-31 19:26:40 +07:00
viettranx 49f51da81c fix(kg): raise extraction temperature from 0.0 to 0.2
Zero temperature was too rigid, causing LLM to miss implied entities
and relations. 0.2 allows picking up contextual connections while
staying deterministic for structured JSON output.
2026-03-31 19:06:38 +07:00
viettranx c49952a1e5 feat(kg): expand entity types and improve extraction prompt
Add 3 new entity types: technology, product, document — reducing
concept catch-all bucket. Add 4 new relation types: authored,
references, provides, requires. Improve prompt with disambiguation
guide between similar types, stricter related_to usage, and varied
confidence examples. Update graph view colors and mass for new types.
2026-03-31 19:03:43 +07:00
viettranx 09a7823498 feat(providers): add tool schema normalization for MCP tools
Port TypeScript schema normalization pipeline to Go. MCP tools with
complex JSON Schemas ($ref, anyOf/oneOf, const, constraints) were
being rejected by OpenAI, Gemini, Codex, and xAI providers.

Pipeline per provider:
- Anthropic: resolve $ref → strip ref keys
- OpenAI/Codex/default: resolve $ref → flatten unions → inject type
- Gemini: resolve $ref → strip nulls → flatten → const→enum → strip 20+ keys
- xAI: resolve $ref → flatten → inject type → strip constraints

Key fixes:
- $ref resolution with circular detection (was: stripped → empty schema)
- anyOf/oneOf flattening into merged objects (was: raw → provider reject)
- type:"object" injection for OpenAI/Codex (was: 400 error)
- Codex now runs normalization (was: zero cleaning)
- Gemini strips 20+ constraint keywords (was: 5)
- xAI constraint keyword stripping (was: no profile)
- Builtin web_search/web_fetch minimum/maximum now stripped for Gemini/xAI
- DB provider type detection via schemaProviderName() for reliable Gemini matching
- Recursion depth guard (maxSchemaDepth=64) prevents DoS from malicious schemas
- Type inference from const values when explicit type is omitted
2026-03-31 17:56:24 +07:00
viettranx 37058918a0 feat(kg): enlarge entity detail dialog with table/graph tabs
Enlarge dialog max-w-3xl→5xl. Split relations into Table and Graph
tabs — graph tab renders traversal results as ReactFlow visualization.
Auto-traverse on open, bump depth 2→3 hops. Update i18n (en/vi/zh).
2026-03-31 17:55:35 +07:00
viettranx b99f119e37 feat(kg): bidirectional multi-hop traversal
Add reverse-edge UNION ALL to recursive CTE so traversal follows both
source→target and target→source edges. Reverse edges prefixed with ~
in via field (e.g. ~manages). Tool output shows directional arrows.
2026-03-31 17:55:27 +07:00
Plateau Nguyenandviettranx 9ad4a879d5 fix(discord): preserve attachment source URL in media tags (#606)
* fix(discord): preserve attachment source URL in media tags (#602)

- Add SourceURL field to MediaInfo struct
- Populate SourceURL from Discord attachment URL in resolveMedia()
- Emit <media:image url="..."> in BuildMediaTags() when SourceURL is set
- Refactor enrichImageIDs/enrichImagePaths with helper functions
- Add comprehensive unit tests for media URL handling

* fix: update system prompt for url attribute + add enrichment regression tests

- System prompt now documents the url attribute in <media:image> tags
- Add TestEnrichImageIDs_BareTag for non-Discord channel enrichment
- Add TestEnrichImageIDs_SkipsAlreadyEnriched for double-enrichment safety
- Add TestEnrichImagePaths_NoDoubleEnrich for historical message safety
- Add TestEnrichImagePaths_AttributeOrderIndependence for url-before-id tags

---------

Co-authored-by: viettranx <viettranx@gmail.com>
2026-03-31 17:16:45 +07:00
viettranx 8372298fba fix(providers): xAI generation models bypass chat verification
grok-imagine-video and grok-2-image were not in the isNonChatModel()
allowlist, causing verify to call Chat API which fails with malformed
error. Also fix friendlyVerifyError() fallback splitting inside JSON
values via LastIndex.
2026-03-31 14:35:57 +07:00
viettranx a565ad8402 fix: preserve FinishReason on truncated tool calls + ParseError propagation (#605)
Three layered bugs caused OpenAI-compatible providers to silently
produce empty tool call arguments when max_tokens was hit mid-JSON:

1. FinishReason override: all providers unconditionally overwrote
   "length" → "tool_calls" when tool calls existed, preventing the
   agent loop's truncation guard from firing.

2. Silent parse failure: JSON unmarshal errors were logged but args
   stayed as empty map with no signal to the caller.

3. No fallback for unreliable providers: some proxies don't emit
   finish_reason:"length" at all, leaving no detection path.

Fixes:
- Add ParseError field to ToolCall struct for explicit error signal
- Guard FinishReason override with `!= "length"` in OpenAI, Codex
- Set ParseError in all provider parsers (OpenAI, Anthropic, Codex)
- Add hasParseErrors() fallback guard in agent loop for EC-5 scenario
- Cap consecutive truncation retries (maxTruncationRetries=3) to
  prevent burning all iterations when max_tokens is persistently low

Closes #605
2026-03-31 14:33:33 +07:00
viettranx 4e9ce0e0e1 fix(contacts): consistent sender_id format and show contact_type in UI
- Use senderID (id|username) instead of userID in group no-mention path,
  preventing duplicate contacts for the same Telegram user
- Use full name (FirstName + LastName) in both contact insert paths
- Show contact_type (User/Group) instead of peer_kind (Direct/Group) in
  contacts table TYPE column and filter dropdown
- Add contact_type filter support in HTTP handler, PG and SQLite stores
2026-03-31 14:18:09 +07:00
viettranx 36b43ed7f1 feat(workspace): leader dual workspace with auto-copy to team on delegate
- Revert leader workspace override: leader keeps personal workspace as
  default, team workspace accessible via ToolTeamWorkspaceFromCtx
- Auto-copy: when leader creates team_tasks, scan subject+description
  for file paths → copy from personal to team workspace so members can
  access them
- Safety: Lstat (reject symlinks), 10MB size cap, .env excluded from
  allowed extensions, path traversal blocked
- Prompt hint: clarify members can only access team workspace files,
  referenced files are auto-copied
2026-03-31 12:10:55 +07:00
viettranx 8193d10fe9 docs: update architecture and changelog for subagent enhancement (#600) 2026-03-31 11:54:00 +07:00
viettranx 63878b16ca feat(telegram): /subagents commands + functional options refactor (#600)
- New /subagents and /subagent <id> commands for viewing subagent tasks
  from the persistent DB table
- Inline keyboard with sa: callback prefix for detail view
- Refactor telegram.New() to functional options pattern (WithAgentStore,
  WithTeamStore, WithSubagentTaskStore, WithPendingMessageStore)
- Wire SubagentTaskStore via WithSubagentTaskStore option
2026-03-31 11:45:25 +07:00