Files
Duc Nguyenandntduc bb7712a9ff fix(collaboration): harden delegated task isolation (#1486)
* feat(collaboration): isolate delegated artifacts and child runs

Isolate delegated inputs and outputs behind secure artifact exchange lifecycles. Scope Agent Link tasks by tenant and root agent, and enforce delegation spawn-tree boundaries. Add process-wide child-run admission and preserve logical media paths across native, MCP, and sandbox execution.

* fix(collaboration): harden delegated task isolation

Enforce tenant and root-agent task scope across migrations and stores. Add exactly-once async completion delivery, delegated sandbox boundaries, and confined artifact and media recovery across runtime surfaces.

* fix(collaboration): recover interrupted async tasks

* fix(collaboration): normalize persisted child-run status

---------

Co-authored-by: ntduc <ntduc@cpp.ai.vn>
2026-07-30 14:17:40 +07:00

91 lines
2.5 KiB
Go

package tools
import (
"context"
"strings"
"testing"
"github.com/nextlevelbuilder/goclaw/internal/providers"
)
func TestReadImage_BothPathAndUrl_Error(t *testing.T) {
tool := NewReadImageTool(nil)
res := tool.Execute(context.Background(), map[string]any{
"prompt": "describe this",
"path": "workspace/image.png",
"url": "https://example.com/image.png",
})
if !res.IsError {
t.Fatalf("expected error when both path and url are provided")
}
if !strings.Contains(res.ForLLM, "Both 'path' and 'url' parameters cannot be specified") {
t.Errorf("unexpected error message: %s", res.ForLLM)
}
}
func TestReadImage_PrivateURL_Error(t *testing.T) {
tool := NewReadImageTool(nil)
res := tool.Execute(context.Background(), map[string]any{
"prompt": "describe this",
"url": "http://127.0.0.1/image.png",
})
if !res.IsError {
t.Fatalf("expected error for private image URL")
}
if !strings.Contains(res.ForLLM, "Invalid image URL") {
t.Errorf("unexpected error message: %s", res.ForLLM)
}
}
func TestResolveImageMediaRefRequiresExactID(t *testing.T) {
ctx := WithMediaImageRefs(context.Background(), []providers.MediaRef{
{ID: "first-id", Kind: "image", Path: ".uploads/first.png"},
{ID: "second-id", Kind: "image", Path: ".uploads/second.png"},
})
got, err := resolveImageMediaRef(ctx, "first-id")
if err != nil || got.ID != "first-id" {
t.Fatalf("exact media ID = %#v, %v", got, err)
}
latest, err := resolveImageMediaRef(ctx, "latest")
if err != nil || latest.ID != "second-id" {
t.Fatalf("latest media ID = %#v, %v", latest, err)
}
if _, err := resolveImageMediaRef(ctx, "missing-id"); err == nil {
t.Fatal("unknown media ID unexpectedly resolved")
}
}
func TestReadImage_AnthropicURL_Error(t *testing.T) {
tool := NewReadImageTool(nil)
params := map[string]any{
"prompt": "describe this",
"images": []providers.ImageContent{
{
URL: "https://93.184.216.34/image.png",
},
},
}
_, _, err := tool.callProvider(context.Background(), nil, "anthropic", "claude-3-sonnet", params)
if err == nil {
t.Fatalf("expected error for anthropic provider with image URL")
}
if !strings.Contains(err.Error(), "does not support analyzing images directly from a URL") {
t.Errorf("unexpected error message: %v", err)
}
// Should also error for claude-cli
_, _, err = tool.callProvider(context.Background(), nil, "claude-cli", "claude-3-sonnet", params)
if err == nil {
t.Fatalf("expected error for claude-cli provider with image URL")
}
}