tiennm99/java-design-patterns
1
0 Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-10-20 02:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,933 Commits 2 Branches 0 Tags
4dbf646b37ddaec5da26a3892c1374e55b8e4aaa
Commit Graph
5 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
mahendran.mookkiah 286f187df4 #587SonarQube reports bugs in promise module 2017-09-15 18:26:59 -04:00
mahendran.mookkiah e9579633da #587 SonarQube reports bugs in dao module 2017-09-15 17:39:01 -04:00
mahendran.mookkiah 51751ec821 #587 SonarQube reports bugs reader-writer-lock and refactor 
Keeping wait() calls with in synchronized block closely to adhere
SonarQube rules.
 
Avoid nested synchronized block by extracting method.

Added writing and reading time to simulate testing to ensure 
1) writers are waiting for globalMutex to be empty 
2) readers to confirm there is no writers.
 2017-08-18 20:44:28 -04:00
mahendran.mookkiah 2a7feba427 #587 SonarQube reports bugs 
As recommended in
https://sonarcloud.io/organizations/default/rules#rule_key=squid%3AS2274 
Used while insteadof if - for waiting upon a condition.
 2017-08-18 14:18:43 -04:00
mahendran.mookkiah a1a4088087 As getAll method returns a Stream, we cannot close the involved 
resources (Connection, Statement and resultSet) until the stream is
closed by the consumer. So try-with-resources is not an option as per
sonarqube’s recommendation. But it is still recommended to close
statement and result set. When connection pool used, connection is not
closed when close() called. It is just returned to the pool.

Using //NOSONAR to avoid false blocker issue.
 2017-08-13 10:19:48 -04:00