java-design-patterns

tiennm99/java-design-patterns

0 Fork 0

mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-10-20 02:17:35 +00:00

Commit Graph

Author	SHA1	Message	Date
mahendran.mookkiah	2a7feba427	#587 SonarQube reports bugs As recommended in https://sonarcloud.io/organizations/default/rules#rule_key=squid%3AS2274 Used while insteadof if - for waiting upon a condition.	2017-08-18 14:18:43 -04:00
mahendran.mookkiah	a1a4088087	As getAll method returns a Stream, we cannot close the involved resources (Connection, Statement and resultSet) until the stream is closed by the consumer. So try-with-resources is not an option as per sonarqube’s recommendation. But it is still recommended to close statement and result set. When connection pool used, connection is not closed when close() called. It is just returned to the pool. Using //NOSONAR to avoid false blocker issue.	2017-08-13 10:19:48 -04:00

Author

SHA1

Message

Date

mahendran.mookkiah

2a7feba427

#587 SonarQube reports bugs

As recommended in
https://sonarcloud.io/organizations/default/rules#rule_key=squid%3AS2274 
Used while insteadof if - for waiting upon a condition.

2017-08-18 14:18:43 -04:00

mahendran.mookkiah

a1a4088087

As getAll method returns a Stream, we cannot close the involved

resources (Connection, Statement and resultSet) until the stream is
closed by the consumer. So try-with-resources is not an option as per
sonarqube’s recommendation. But it is still recommended to close
statement and result set. When connection pool used, connection is not
closed when close() called. It is just returned to the pool.

Using //NOSONAR to avoid false blocker issue.

2017-08-13 10:19:48 -04:00