tiennm99/lombok
1
0 Fork 0
mirror of https://github.com/tiennm99/lombok.git synced 2026-10-14 02:16:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Code review

Browse Source
This commit is contained in:
Roel Spilker committed 2012-01-09 20:42:10 +01:00
1 parent 3796efe82e
commit 1085c902ca
2 files changed
+27 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java
+1 -1
View File
@@ -115,7 +115,7 @@ public class EclipsePatcher extends Agent {
/* Make sure the generated source element is found instead of the annotation */
sm.addScript(ScriptBuilder.wrapMethodCall()
.target(new MethodTarget("org.eclipse.jdt.internal.corext.refactoring.structure.ExtractInterfaceProcessor", "createMethodDeclaration", "void",
.target(new MethodTarget("org.eclipse.jdt.internal.corext.refactoring.structure.ExtractInterfaceProcessor", "createMethodDeclaration", "void",
"org.eclipse.jdt.internal.corext.refactoring.structure.CompilationUnitRewrite",
"org.eclipse.jdt.core.dom.rewrite.ASTRewrite",
"org.eclipse.jdt.core.dom.AbstractTypeDeclaration",
src/eclipseAgent/lombok/eclipse/agent/PatchFixes.java
+26 -9
View File
@@ -84,16 +84,33 @@ public class PatchFixes {
/* Very practical implementation, but works for getter and setter even with type parameters */
public static java.lang.String getRealMethodDeclarationSource(java.lang.String original, org.eclipse.jdt.core.dom.MethodDeclaration declaration) {
if(isGenerated(declaration)) {
String returnType = declaration.getReturnType2().toString();
String params = "";
for (Object object : declaration.parameters()) {
org.eclipse.jdt.core.dom.ASTNode parameter = ((org.eclipse.jdt.core.dom.ASTNode)object);
params += ","+parameter.toString();
}
return returnType + " "+declaration.getName().getFullyQualifiedName()+"("+(params.isEmpty() ? "" : params.substring(1))+");";
if (!isGenerated(declaration)) return original;
StringBuilder signature = new StringBuilder();
// We should get these from the refactor action
boolean needsPublic = true, needsAbstract = true;
if (needsPublic) signature.append("public ");
if (needsAbstract) signature.append("abstract ");
signature
.append(declaration.getReturnType2().toString())
.append(" ").append(declaration.getName().getFullyQualifiedName())
.append("(");
boolean first = true;
for (Object parameter : declaration.parameters()) {
if (!first) signature.append(", ");
first = false;
// The annotations are still missing
// Note: what happens to imports for the annotations?
// I assume they have been taken care of by the default extraction system
signature.append(parameter);
}
return original;
signature.append(");");
return signature.toString();
}