Hide implicit constructors in eclipse tests

The output varies in newer eclipse versions. To address this, lombok now
disables the printing of implicit constructors for eclipse.

src/eclipseAgent/lombok/eclipse/agent/EclipsePatcher.java

@@ -1028,6 +1028,14 @@ public class EclipsePatcher implements AgentLauncher.AgentLaunchable {
 				.request(StackRequest.RETURN_VALUE, StackRequest.PARAM1)
 				.wrapMethod(new Hook("lombok.launch.PatchFixesHider$Tests", "getBundle", "java.lang.Object", "java.lang.Object", "java.lang.Class"))
 				.build());
+		
+		sm.addScriptIfWitness(new String[] {"lombok/transform/TestWithEcj"}, ScriptBuilder.exitEarly()
+				.target(new MethodTarget("org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration", "print"))
+				.decisionMethod(new Hook("lombok.launch.PatchFixesHider$Tests", "isImplicitCanonicalConstructor", "boolean", "org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration", "java.lang.Object"))
+				.valueMethod(new Hook("lombok.launch.PatchFixesHider$Tests", "returnStringBuffer", "java.lang.StringBuffer", "java.lang.Object", "java.lang.StringBuffer"))
+				.request(StackRequest.THIS, StackRequest.PARAM2)
+				.transplant()
+				.build());
 	}
 
 }

src/eclipseAgent/lombok/launch/PatchFixesHider.java

@@ -21,6 +21,9 @@
  */
 package lombok.launch;
 
+import static lombok.eclipse.EcjAugments.ASTNode_generatedBy;
+import static lombok.eclipse.Eclipse.*;
+
 import java.io.BufferedOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
@@ -62,8 +65,6 @@ import org.eclipse.jdt.internal.corext.refactoring.structure.MemberVisibilityAdj
 
 import lombok.permit.Permit;
 
-import static lombok.eclipse.EcjAugments.ASTNode_generatedBy;
-
 /** These contain a mix of the following:
  * <ul>
  * <li> 'dependency free' method wrappers that cross the shadowloader barrier.
@@ -925,5 +926,13 @@ final class PatchFixesHider {
 			}
 			return null;
 		}
+		
+		public static boolean isImplicitCanonicalConstructor(AbstractMethodDeclaration method, Object parameter) {
+			return (method.bits & IsCanonicalConstructor) != 0 && (method.bits & IsImplicit) != 0;
+		}
+		
+		public static StringBuffer returnStringBuffer(Object p1, StringBuffer buffer) {
+			return buffer;
+		}
 	}
 }

test/core/src/lombok/RunTestsViaEcj.java

@@ -99,6 +99,7 @@ public class RunTestsViaEcj extends AbstractRunTests {
 		warnings.put(CompilerOptions.OPTION_ReportNonStaticAccessToStatic, "warning");
 		warnings.put("org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures", "ignore");
 		warnings.put(CompilerOptions.OPTION_Source, (ecjCompilerVersion < 9 ? "1." : "") + ecjCompilerVersion);
+		warnings.put("org.eclipse.jdt.core.compiler.codegen.useStringConcatFactory", "disabled");
 		options.set(warnings);
 		return options;
 	}

test/transform/resource/after-ecj/BuilderSimpleOnRecord.java

@@ -30,11 +30,6 @@ public @lombok.Builder(access = lombok.AccessLevel.PROTECTED) record BuilderSimp
   }
 /* Implicit */  private final List<T> l;
 /* Implicit */  private final String a;
-  public BuilderSimpleOnRecord(List<T> l, String a) {
-    super();
-    .l = l;
-    .a = a;
-  }
   protected static @java.lang.SuppressWarnings("all") <T>BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder<T> builder() {
     return new BuilderSimpleOnRecord.BuilderSimpleOnRecordBuilder<T>();
   }

test/transform/resource/after-ecj/BuilderSingularOnRecord.java

@@ -117,12 +117,6 @@ public @Builder record BuilderSingularOnRecord(List children, Collection scarves
 /* Implicit */  private final List<T> children;
 /* Implicit */  private final Collection<? extends Number> scarves;
 /* Implicit */  private final List rawList;
-  public BuilderSingularOnRecord(@Singular List<T> children, @Singular Collection<? extends Number> scarves, @SuppressWarnings("all") @Singular("rawList") List rawList) {
-    super();
-    .children = children;
-    .scarves = scarves;
-    .rawList = rawList;
-  }
   public static @java.lang.SuppressWarnings("all") <T>BuilderSingularOnRecord.BuilderSingularOnRecordBuilder<T> builder() {
     return new BuilderSingularOnRecord.BuilderSingularOnRecordBuilder<T>();
   }

test/transform/resource/after-ecj/ConstructorsOnRecord.java

@@ -5,9 +5,4 @@ import lombok.RequiredArgsConstructor;
 public @AllArgsConstructor @RequiredArgsConstructor @NoArgsConstructor record ConstructorsOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public ConstructorsOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/DataOnRecord.java

@@ -3,9 +3,4 @@ import lombok.Data;
 public @Data record DataOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public DataOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/EqualsAndHashCodeOnRecord.java

@@ -3,9 +3,4 @@ import lombok.EqualsAndHashCode;
 public @EqualsAndHashCode record EqualsAndHashCodeOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public EqualsAndHashCodeOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/ExtensionMethodOnRecord.java

@@ -9,9 +9,6 @@ public @ExtensionMethod(ExtensionMethodOnRecord.Extensions.class) record Extensi
       return Integer.valueOf(s);
     }
   }
-  public ExtensionMethodOnRecord() {
-    super();
-  }
   public void test() {
     ExtensionMethodOnRecord.Extensions.intValue("1");
   }

test/transform/resource/after-ecj/FieldDefaultsOnRecord.java

@@ -2,9 +2,4 @@
 public @lombok.experimental.FieldDefaults(makeFinal = true) record FieldDefaultsOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public FieldDefaultsOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/FieldDefaultsViaConfigOnRecord.java

@@ -2,9 +2,4 @@
 public record FieldDefaultsViaConfigOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public FieldDefaultsViaConfigOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/FieldNameConstantsOnRecord.java

@@ -18,11 +18,4 @@ public @FieldNameConstants(level = AccessLevel.PACKAGE) record FieldNameConstant
   static double skipMeToo;
   <clinit>() {
   }
-  public FieldNameConstantsOnRecord(String iAmADvdPlayer, int $skipMe,  int andMe, String butPrintMePlease) {
-    super();
-    .iAmADvdPlayer = iAmADvdPlayer;
-    .$skipMe = $skipMe;
-    .andMe = andMe;
-    .butPrintMePlease = butPrintMePlease;
-  }
 }

test/transform/resource/after-ecj/GetterOnRecord.java

@@ -3,9 +3,4 @@ import lombok.Getter;
 public @Getter record GetterOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public GetterOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/JacksonizedOnRecord.java

@@ -58,11 +58,6 @@ public @lombok.extern.jackson.Jacksonized @lombok.Builder @JsonIgnoreProperties
   }
 /* Implicit */  private final String string;
 /* Implicit */  private final List<String> values;
-  public JacksonizedOnRecord(@JsonProperty("test") @Nullable String string, @lombok.Singular List<String> values) {
-    super();
-    .string = string;
-    .values = values;
-  }
   public static @java.lang.SuppressWarnings("all") JacksonizedOnRecord.JacksonizedOnRecordBuilder builder() {
     return new JacksonizedOnRecord.JacksonizedOnRecordBuilder();
   }

test/transform/resource/after-ecj/LockedInRecord.java

@@ -3,11 +3,6 @@ public record LockedInRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
   private final java.util.concurrent.locks.Lock $lock = new java.util.concurrent.locks.ReentrantLock();
-  public LockedInRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   public @Locked void foo() {
     String foo = "bar";
   }

test/transform/resource/after-ecj/LoggerConfigOnRecord.java

@@ -3,9 +3,4 @@ import lombok.extern.slf4j.Slf4j;
 public @Slf4j record LoggerConfigOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public LoggerConfigOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/LoggerFloggerRecord.java

@@ -6,10 +6,6 @@ class LoggerFloggerRecord {
     private static final com.google.common.flogger.FluentLogger log = com.google.common.flogger.FluentLogger.forEnclosingClass();
     <clinit>() {
     }
-    public Inner(String x) {
-      super();
-      .x = x;
-    }
   }
   LoggerFloggerRecord() {
     super();

test/transform/resource/after-ecj/LoggerSlf4jOnRecord.java

@@ -6,9 +6,4 @@ public @Slf4j record LoggerSlf4jOnRecord(String a, String b) {
   private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LoggerSlf4jOnRecord.class);
   <clinit>() {
   }
-  public LoggerSlf4jOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/SetterOnRecord.java

@@ -3,9 +3,4 @@ import lombok.Setter;
 public @Setter record SetterOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public SetterOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/SynchronizedInRecord.java

@@ -3,11 +3,6 @@ public record SynchronizedInRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
   private final java.lang.Object $lock = new java.lang.Object[0];
-  public SynchronizedInRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   public @Synchronized void foo() {
     String foo = "bar";
   }

test/transform/resource/after-ecj/ToStringOnRecord.java

@@ -3,9 +3,4 @@ import lombok.ToString;
 public @ToString record ToStringOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public ToStringOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/UtilityClassOnRecord.java

@@ -3,9 +3,4 @@ import lombok.experimental.UtilityClass;
 public @UtilityClass record UtilityClassOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public UtilityClassOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/ValueOnRecord.java

@@ -3,9 +3,4 @@ import lombok.Value;
 public @Value record ValueOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public ValueOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
 }

test/transform/resource/after-ecj/WithByOnRecord.java

@@ -3,11 +3,6 @@ import lombok.experimental.WithBy;
 public @WithBy record WithByOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public WithByOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   public @java.lang.SuppressWarnings("all") WithByOnRecord withABy(final java.util.function.Function<? super String, ? extends String> transformer) {
     return new WithByOnRecord(transformer.apply(this.a), this.b);
   }

test/transform/resource/after-ecj/WithByOnRecordComponent.java

@@ -3,11 +3,6 @@ import lombok.experimental.WithBy;
 public record WithByOnRecordComponent(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public WithByOnRecordComponent( String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   public @java.lang.SuppressWarnings("all") WithByOnRecordComponent withABy(final java.util.function.Function<? super String, ? extends String> transformer) {
     return new WithByOnRecordComponent(transformer.apply(this.a), this.b);
   }

test/transform/resource/after-ecj/WithOnRecord.java

@@ -3,11 +3,6 @@ import lombok.With;
 public @With record WithOnRecord(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public WithOnRecord(String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   /**
    * @return a clone of this object, except with this updated property (returns {@code this} if an identical value is passed).
    */

test/transform/resource/after-ecj/WithOnRecordComponent.java

@@ -3,11 +3,6 @@ import lombok.With;
 public record WithOnRecordComponent(String a, String b) {
 /* Implicit */  private final String a;
 /* Implicit */  private final String b;
-  public WithOnRecordComponent( String a, String b) {
-    super();
-    .a = a;
-    .b = b;
-  }
   /**
    * @return a clone of this object, except with this updated property (returns {@code this} if an identical value is passed).
    */