Handlers and testcases for @CommonsLog

src/core/lombok/eclipse/handlers/HandleLog.java

@@ -161,7 +161,7 @@ public class HandleLog {
 	@ProviderFor(EclipseAnnotationHandler.class)
 	public static class HandleCommonsLog extends EclipseAnnotationHandler<lombok.extern.apachecommons.CommonsLog> {
 		@Override public void handle(AnnotationValues<lombok.extern.apachecommons.CommonsLog> annotation, Annotation source, EclipseNode annotationNode) {
-			processAnnotation(LoggingFramework.COMMONS, annotation, source, annotationNode, "");
+			processAnnotation(LoggingFramework.COMMONS, annotation, source, annotationNode, annotation.getInstance().value());
 		}
 	}
 	

src/core/lombok/extern/apachecommons/CommonsLog.java

@@ -59,4 +59,8 @@ import java.lang.annotation.Target;
 @Retention(RetentionPolicy.SOURCE)
 @Target(ElementType.TYPE)
 public @interface CommonsLog {
+	/**
+	 * Sets the category of the constructed Logger. By default, it will use the type where the annotation is placed.
+	 */
+	String value() default "";
 }

src/core/lombok/javac/handlers/HandleLog.java

@@ -111,7 +111,7 @@ public class HandleLog {
 	@ProviderFor(JavacAnnotationHandler.class)
 	public static class HandleCommonsLog extends JavacAnnotationHandler<lombok.extern.apachecommons.CommonsLog> {
 		@Override public void handle(AnnotationValues<lombok.extern.apachecommons.CommonsLog> annotation, JCAnnotation ast, JavacNode annotationNode) {
-			processAnnotation(LoggingFramework.COMMONS, annotation, annotationNode, "");
+			processAnnotation(LoggingFramework.COMMONS, annotation, annotationNode, annotation.getInstance().value());
 		}
 	}
 	

test/transform/resource/after-delombok/LoggerCommons.java

@@ -5,4 +5,8 @@ class LoggerCommons {
 class LoggerCommonsWithImport {
 	@java.lang.SuppressWarnings("all")
 	private static final org.apache.commons.logging.Log log = org.apache.commons.logging.LogFactory.getLog(LoggerCommonsWithImport.class);
+}
+class LoggerCommonsWithDifferentName {
+	@java.lang.SuppressWarnings("all")
+	private static final org.apache.commons.logging.Log log = org.apache.commons.logging.LogFactory.getLog("DifferentName");
 }

test/transform/resource/after-ecj/LoggerCommons.java

@@ -14,4 +14,12 @@ import lombok.extern.apachecommons.CommonsLog;
   LoggerCommonsWithImport() {
     super();
   }
+}
+@CommonsLog("DifferentName") class LoggerCommonsWithDifferentName {
+  private static final org.apache.commons.logging.Log log = org.apache.commons.logging.LogFactory.getLog("DifferentName");
+  <clinit>() {
+  }
+  LoggerCommonsWithDifferentName() {
+    super();
+  }
 }

test/transform/resource/before/LoggerCommons.java

@@ -6,4 +6,8 @@ class LoggerCommons {
 
 @CommonsLog
 class LoggerCommonsWithImport {
-}
+}
+
+@CommonsLog("DifferentName")
+class LoggerCommonsWithDifferentName {
+}