Commit Graph
621 Commits
Author SHA1 Message Date
Reinier Zwitserloot ceda2e5efe toString(), equals(), and hashCode() now use getX() instead of x if either it exists OR it will be generated by some other lombok annotation, addressing issue #110.
code deduplication by removing HandleData's scanning for fields, which is now no longer done; the sub-parts of Data (Getter, Setter, RequiredArgsConstructor, etc) take care of it now.

fix for class-level @Getter/@Setter, which used to go for every field. Now they skip the usual fields (static, for setters final, and $ prefixed fields).

Bugfix for @Data not recognizing that it should let field-level @Getter/@Setter take care of generating the getter/setter for multi field declarations (@Getter int x, y);
2010-07-22 14:19:23 +02:00
Reinier Zwitserloot 868d8b0f93 Updated copyright statements and version release name. 2010-07-22 14:16:18 +02:00
Reinier Zwitserloot 0a9d754fa5 eclipse toString() now uses .getX() instead of .x. 2010-07-22 01:59:58 +02:00
Reinier Zwitserloot 3e2392fb30 Compatibility update for PrettyCommentsPrinter, which should now work better in javac 7. 2010-07-22 01:59:43 +02:00
Reinier Zwitserloot 7c47aa1125 Added more tests, one of which tests usage of .getX() in toString, equals, and hashCode, which isn't fully working yet, so this test still fails. 2010-07-22 01:59:30 +02:00
Reinier Zwitserloot 483e23d385 Added tests for ecj, fixed a few minor bugs that came out of that. 2010-07-22 01:33:24 +02:00
Reinier Zwitserloot 59e585a0c6 refactored the tests to prepare running ecj as well as delombok. 2010-07-21 23:52:28 +02:00
Reinier Zwitserloot 1a9f8f168a delombok on most javacs would quit with a NoSuchFieldError if it contains <?> style wildcards anywhere in the source. No longer.
Fixes issue #134.
2010-07-21 23:05:28 +02:00
Reinier Zwitserloot 91bb3455da Added using .getX() instead of using .x in equals, hashCode, and toString. Also updated changelog as well as the docs.
Also updated usage examples for @EqualsAndHashCode, @ToString, and @Data, which also contained some other minor issues (such as missing this. qualifiers).

Still to do is to detect that getters don't exist _yet_ but will later due to @Getter or @Data.
2010-07-21 10:51:09 +02:00
Reinier Zwitserloot c06660bd18 Refactor: for using this.getX() instead of this.x in generated toString(), equals(), and hashCode() methods. Field accessors are now always generated by a utility method. The one thing that remains is adding a getter searcher to this utility method. 2010-07-21 10:19:13 +02:00
Reinier Zwitserloot 33b3e798fd Added some 'live debugging' - patches to improve error reporting for bugs that are very hard to reproduce. 2010-07-21 10:16:46 +02:00
Roel Spilker 8e1cbe1b10 Added checks for warnings in test cases 2010-07-20 23:52:13 +02:00
Roel Spilker ced6843970 Added support for checking compiler messages (errors & warnings) 2010-07-20 23:51:47 +02:00
Roel Spilker 58f5f68f05 Added support for setting up an alternative diagnostics listener 2010-07-20 23:50:55 +02:00
Roel Spilker b6d468144d Added tests for @Getter and @Setter on a class[B 2010-07-20 22:22:12 +02:00
Reinier Zwitserloot b494720949 Small updates to website docs after feedback from RJ and Roel. 2010-07-20 12:32:19 +02:00
Reinier Zwitserloot 0892b61180 Updated credits to list Petr Jiricka and Cobertura, also updated copyright year for the index page. 2010-07-20 12:27:24 +02:00
Reinier Zwitserloot a9ed18ac85 bugfix: The previous fix to stop removal of lombok annotations unless delombok is running actually only worked for the import, and still deleted the annotation. No longer. 2010-07-20 12:06:20 +02:00
Reinier Zwitserloot db6a456557 Merge branch 'master' of github.com:rzwitserloot/lombok 2010-07-20 12:00:10 +02:00
Reinier Zwitserloot d7ee0bc8a5 @Getter int x, y; used to only apply to 'x', now it applies to both x and y.
Fixes issue #54
2010-07-20 11:58:56 +02:00
Roel Spilker 6daa9cdbe3 Added references to other constructor annotations in the javadoc 2010-07-20 11:54:21 +02:00
Reinier Zwitserloot ba7406f05a Moved DeleteLombokAnnotations to the proper package and source dir. 2010-07-20 11:00:38 +02:00
Reinier Zwitserloot 178f628565 import lombok.*; wasn't working in eclipse. It is now.
Fixes issue #102.
2010-07-20 10:39:19 +02:00
Reinier Zwitserloot aaf8547d91 Added documentation for @RequiredArgsConstructor, @NoArgsConstructor, @AllArgsConstructor, and also how these generate @ConstructorProperties annotations.
Also updated @Getter and @Setter's documentation to explain their new class-level feature, and updated @Data's description to highlight how @Data is now truly nothing more than the combination of @RequiredArgsConstructor, @EqualsAndHashCode, @ToString, @Getter, and @Setter.
2010-07-20 07:43:02 +02:00
Reinier Zwitserloot f17ba28daa Added copyright header to DelombokApp.java 2010-07-20 07:03:20 +02:00
Reinier Zwitserloot 77ff3ca2c3 import lombok.AccessLevel is now also removed during delomboking.
Also, when NOT running delombok, the javac processors no longer delete the lombok annotations as they process. This is particularly relevant for netbeans.

This fixes issue #100 and #103.
2010-07-20 07:03:07 +02:00
Reinier Zwitserloot 4e40de2f88 Whoops, the junit dependency descriptor was misnamed. 2010-07-20 06:28:40 +02:00
Roel Spilker c5a31a3768 Made more consistent 2010-07-20 02:06:06 +02:00
Roel Spilker 4d2eaa3653 Published the test target 2010-07-20 01:42:23 +02:00
Roel Spilker 0d7df01a07 Updated the tests to reflect recent modifications: use 'this' where possible and add @SuppressWarnings for all generated fields and methods. 2010-07-20 01:35:40 +02:00
Roel Spilker 9b886c140c Changed the order of unpacking libs to be before compiling in the build script, this way having old versions of e.g. lombok.patcher around dont mysteriously break your build until you ant clean. 2010-07-20 00:44:36 +02:00
Reinier Zwitserloot 01ff2a8b79 With the new features, some of the delombok based unit tests no longer work. 2010-07-20 00:39:04 +02:00
Reinier Zwitserloot 78aa370b14 Whoops, 2 dependency descriptors were missing. Added them. 2010-07-20 00:38:38 +02:00
Roel Spilker 45460230a5 Fixed some broken dependency descriptors 2010-07-20 00:34:09 +02:00
Reinier Zwitserloot 5c6fe62a85 Added support for @ConstructorProperties generation for generated constructors.
Also added fix: @Constructor with access level none are now no longer generated.

Implements issue #122
2010-07-19 23:48:12 +02:00
Reinier Zwitserloot 734baebfa9 [TRIVIAL] in case of bugs and we drop to toModifier() for AccessLevel.NONE, we now make a private method/constructor instead of a public one. Still not right, but less wrong than public. 2010-07-19 23:41:44 +02:00
Reinier Zwitserloot 8c3b34e851 Added javadoc to the annotation parameters for the @Constructor annotations,
and also added the suppressConstructorProperties flag.
2010-07-19 23:40:59 +02:00
Reinier Zwitserloot 067ecf7118 Added support for @NoArgsConstructor, @RequiredArgsConstructor and @AllArgsConstructor for eclipse.
Implements issue #79.
2010-07-19 22:10:43 +02:00
Reinier Zwitserloot 29cd0ac3e7 Added support for @AllArgsConstructor, @NoArgsConstructor, and @RequiredArgsConstructor for javac. 2010-07-19 21:18:16 +02:00
Reinier Zwitserloot b47e87f873 Added (and left intentionally undocumented) an option to force the installer to use an absolute path for location of lombok.jar:
java -Dlombok.installer.fullpath -jar lombok.jar

There have been some reports that under helios the relative path no longer cuts it, but all reports come from tweaked installs. In case folks run into this, we can now give them a quick solution.

See: http://groups.google.com/group/project-lombok/browse_thread/thread/2071edd5495a8cd7
2010-07-19 17:24:58 +02:00
Reinier Zwitserloot a5e19958f6 All generated fields and methods now get a @SuppressWarnings("all").
Implements issue #47.
2010-07-18 01:26:02 +02:00
Reinier Zwitserloot a1629c55ac Updated changelog for fixing issue #48 2010-07-18 00:37:34 +02:00
Reinier Zwitserloot 8869e97594 All field accesses done by generated lombok methods are now qualified with 'this.'
Addresses issue #48
2010-07-18 00:34:22 +02:00
Reinier Zwitserloot 51b031c732 In our efforts to eliminate annotations for delombok, we also eliminated all traces of the annotation for lombok itself. This didn't work well with @Data and how it interacts with existing @Getter/@Setter annotations. @Data scans for those annotations to determine that it shouldn't do anything. By deleting them, this process wasn't working anymore. 2010-07-17 06:58:00 +02:00
Reinier Zwitserloot 89586dd793 Bugfix: Annotations on types were being ignored if the type had no members in it, in javac only. 2010-07-17 06:56:37 +02:00
Reinier Zwitserloot 32a23d7786 Implements issue #129: @Getter and @Setter are now legal on entire types. 2010-07-17 06:54:33 +02:00
Reinier Zwitserloot 99f763a729 Updated spelling of LICENCE to LICENSE, and updated copyright notice of help text printed by main executable. 2010-07-17 05:10:43 +02:00
Reinier Zwitserloot 775ab75ee8 Did some maintainance on the changelog. 2010-07-16 05:55:54 +02:00
Reinier Zwitserloot 3b706b09f7 previous update to the code due to changes in lombok.patcher introduced a bug, which was causing the following exception in the eclipse error log:
java.lang.VerifyError: (class: org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder, method: findByBinding signature: (Lorg/eclipse/jdt/core/dom/ASTNode;Lorg/eclipse/jdt/core/dom/IBinding;)[Lorg/eclipse/jdt/core/dom/SimpleName;) Incompatible argument to function
2010-07-16 04:04:38 +02:00
Reinier Zwitserloot 491d6bf7a4 Updated eclipse dependencies to 3.6.0, and added sources. 2010-07-16 04:03:38 +02:00