mirror of
https://github.com/tiennm99/noitu.git
synced 2026-10-11 03:13:45 +00:00
fix(web): give the board's chat pill its own accessible name
The panel's fold toggle and the header pill both read "Trò chuyện", so a role query, or a screen reader, found two controls with one name.
This commit is contained in:
1 parent
5178a97520
commit
8c3d8f415b
2 files changed
+9
No files matched your search
@@ -138,10 +138,16 @@
|
||||
about. Scrolling the panel into view rather than opening it in
|
||||
place, since a folded panel scrolled here still shows its own
|
||||
badge and its own way to unfold. -->
|
||||
<!-- Its own accessible name: the panel below has a toggle that
|
||||
reads "Trò chuyện" too, and two controls announced alike are
|
||||
one control a screen reader cannot tell apart. -->
|
||||
<button
|
||||
type="button"
|
||||
class="chat-pill"
|
||||
onclick={onchatopen}
|
||||
aria-label={chatUnread > 0
|
||||
? `${t.chatOpen}, ${fill(t.chatUnread, { n: chatUnread })}`
|
||||
: t.chatOpen}
|
||||
data-testid="chat-pill"
|
||||
>
|
||||
{t.chatTitle}
|
||||
|
||||
@@ -122,6 +122,9 @@ export const t = {
|
||||
shareInvite: 'Vào chơi nối từ với tôi',
|
||||
|
||||
chatTitle: 'Trò chuyện',
|
||||
// The board header's shortcut to the panel; distinct from the panel's own
|
||||
// toggle so the two are never announced as the same control.
|
||||
chatOpen: 'Mở trò chuyện',
|
||||
chatPlaceholder: 'Nhắn tin…',
|
||||
chatEmpty: 'Chưa có tin nhắn nào.',
|
||||
chatUnread: '{n} tin mới',
|
||||
|
||||
Reference in new issue
Block a user