tiennm99/open-domains
1
0 Fork 0
mirror of https://github.com/tiennm99/open-domains.git synced 2026-10-13 18:15:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix!: improper validation

Browse Source
This commit is contained in:
DIBSTER authored and GitHub committed 2024-12-05 17:33:58 -05:00
1 parent 2069fa383b
commit ea1519592d
1 file changed
+13 -7
Download Patch File Download Diff File Expand all files Collapse all files
tests/domains.test.js
+13 -7
View File
@@ -15,10 +15,10 @@ t("Nested subdomains should not exist without a parent subdomain", (t) => {
const subdomain = file.replace(/\.json$/, "");
if (subdomain.split(".").length > 1) {
// Get parent domain by removing the last part (subdomain) from the full subdomain
if (subdomain.split(".").length > 2) {
// Get parent domain by removing the leftmost part
const parentSubdomain = subdomain.split(".").slice(1).join(".");
// Ensure the parent subdomain exists
t.true(
files.includes(`${parentSubdomain}.json`),
@@ -40,16 +40,21 @@ t("Nested subdomains should not exist if the parent subdomain has NS records", (
const subdomain = file.replace(/\.json$/, "");
if (subdomain.split(".").length > 1) {
// Get parent domain by removing the last part (subdomain) from the full subdomain
if (subdomain.split(".").length > 2) {
// Get parent domain by removing the leftmost part
const parentSubdomain = subdomain.split(".").slice(1).join(".");
const parentFilePath = path.join(domainsPath, `${parentSubdomain}.json`);
// Check if the parent file exists before attempting to read it
if (fs.existsSync(parentFilePath)) {
const parentDomain = fs.readJsonSync(parentFilePath);
t.is(parentDomain.record.NS, undefined, `${file}: Parent subdomain has NS records`);
// Check if the parent has NS records
t.is(
parentDomain.record.NS,
undefined,
`${file}: Parent subdomain ${parentSubdomain} has NS records`
);
} else {
t.fail(`${parentSubdomain}.json file does not exist`);
}
@@ -58,3 +63,4 @@ t("Nested subdomains should not exist if the parent subdomain has NS records", (
t.pass();
});