mirror of
https://github.com/tiennm99/serena.git
synced 2026-10-13 14:16:21 +00:00
Fix: dashboard "Last Execution" panel stuck on "Loading..." when no execution exists (#1714)
loadLastExecution()'s success handler only called displayLastExecution()
when the backend returned a non-null last_execution, so on a fresh server
(no tool run yet) the initial "Loading..." placeholder was never replaced.
displayLastExecution(null) already renders the correct empty state
("No executions yet.") — it just wasn't being called.
Add the missing else branch, mirroring how the Tool Usage and Executions
Queue panels already handle their empty states.
Fixes #1713
Co-authored-by: arimu1 <19286898+arimu1@users.noreply.github.com>
This commit is contained in:
1 parent
96e95c0b5d
commit
a9067050f2
2 files changed
+8
No files matched your search
@@ -32,6 +32,12 @@ Status of the `main` branch. Changes prior to the next official version change w
|
||||
- used in `JetBrainsFindDeclarationTool`
|
||||
when using plugin version 2023.3.3+
|
||||
|
||||
* Dashboard:
|
||||
- Fix: the "Last Execution" panel stayed on "Loading..." forever when there was no logged execution
|
||||
(e.g. a fresh server / no tool run yet), because `loadLastExecution()` only rendered the panel when
|
||||
the backend returned a non-null execution; the empty state is now rendered via the existing
|
||||
`displayLastExecution(null)` path, mirroring the other panels #1713
|
||||
|
||||
* Dependencies:
|
||||
- Bump mcp from 1.27.0 to 1.28.1
|
||||
|
||||
|
||||
@@ -913,6 +913,8 @@ class Dashboard {
|
||||
if (response.status === 'success') {
|
||||
if (response.last_execution !== null && response.last_execution.logged) {
|
||||
self.displayLastExecution(response.last_execution);
|
||||
} else {
|
||||
self.displayLastExecution(null);
|
||||
}
|
||||
} else {
|
||||
console.error('Error loading last execution:', response.message);
|
||||
|
||||
Reference in new issue
Block a user