Codex can't deal with them, I suspect ChatGPT will also have problems.
This leads to slightly less expressive python code, but it isn't a large problem and is worth
the extension in usability for serena.
* Fix an error that occurred when trying to scan an inaccessible directory
for example, when the directory permissions were set to 700.
* Fix redundant error handling
* Fix format
---------
Co-authored-by: tsukumi <tsukumijima@users.noreply.github.com>
I noticed that models often use `get_symbols_overview` on a directory only to get an error because the tool does not support directories. The issue was that the description and usage instructions for the tool incorrectly mentioned support for directories.
instead of creating new low-level data structures.
This enables uniform handling of required conversions in our
higher-level Serena data structures
Fixes#432
* Add Bundler support for Ruby projects
This change enhances the Solargraph language server implementation to properly support Ruby projects using Bundler with vendor/bundle configurations.
Key improvements:
- Detects Bundler projects by checking for Gemfile existence
- Supports both 'bin/bundle' and 'bundle' commands
- Checks Gemfile.lock for solargraph availability
- Uses 'bundle exec solargraph' when appropriate
- Provides clear error messages for missing solargraph in Bundler projects
- Maintains backward compatibility with non-Bundler projects
Fixes permission issues encountered with rbenv/system-managed Ruby installations
when trying to install gems globally.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Add timeout configuration for Solargraph language server
This change adds proper timeout handling to the Solargraph Ruby language server
to address initialization timeout issues, especially in Bundler environments.
Key improvements:
- Set 120-second request timeout for LSP requests and initialization
- Add 60-second server readiness timeout with graceful fallback
- Enhanced logging for timeout scenarios
- Better handling of slow initialization in large projects or Bundler environments
This resolves connection timeout issues where Solargraph takes longer than
the default 30-second MCP timeout to fully initialize and become ready.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* I've enhanced the Ruby language support in SolidLSP to bring it up to par with the Python implementation, as you requested.
Here are the key changes I made:
1. **Enhanced Solargraph Initialization:** I updated the `solargraph.py` language server to use a more reliable event-based mechanism to wait for the server to be ready, similar to `pyright_server.py`. This replaces the previous timeout-based approach, reducing the likelihood of race conditions and improving reliability.
2. **Improved Initialization Parameters:** The initialization request sent to the Solargraph server now includes a comprehensive set of client capabilities, mirroring the Python implementation. This enables more advanced features and is expected to improve the quality and consistency of the server's responses.
These changes make the Ruby language support more robust and feature-rich without altering the existing tests.
* Enhance Ruby language support to match Python implementation
- Add comprehensive Ruby/Rails exclude patterns for better performance
- Implement Rails project detection with automatic configuration
- Enhance error handling for Ruby, Bundler, and Solargraph installation
- Add Ruby version compatibility checks with warnings for old versions
- Improve directory ignoring for Ruby-specific folders
- Add detailed installation instructions for multiple Ruby managers (rbenv, RVM, asdf)
These improvements bring Ruby language server support up to par with Python,
providing better performance, error messages, and project detection.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Fix Ruff linting error: properly separate string literals
Resolves ISC001 'Implicitly concatenated string literals on one line' by
explicitly separating the f-string and regular string literal in the
error message formatting.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Fix Black/Ruff formatting conflict: unify error message string
Combines the f-string and literal string into a single unified string to
resolve the conflict between Black formatter and Ruff ISC001 rule.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Optimize initializationOptions: remove redundant settings
Remove duplicate settings that match Solargraph defaults:
- diagnostics: true (default: true)
- completion: true (default: true)
- hover: true (default: true)
- formatting: true (default: false, but user preference)
Keep only essential exclude patterns for performance improvement.
This addresses reviewer feedback about unnecessary option duplication.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Optimize Ruby language server capabilities configuration
Based on reviewer feedback in PR #439, optimize the Ruby language server
implementation by removing redundant LSP client capabilities that duplicate
Solargraph's default behavior. This maintains essential functionality while
reducing initialization complexity.
Key optimizations:
- Removed redundant textDocument capabilities that match Solargraph defaults
- Kept only essential capabilities: workspaceEdit, hierarchicalDocumentSymbolSupport, and symbolKind
- Maintained all existing exclude patterns and error handling improvements
- Preserved Rails project detection and Ruby-specific optimizations
The optimized configuration reduces from ~30 lines of capabilities to a minimal
essential set while maintaining full Ruby language server functionality.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Add CHANGELOG entry for Ruby language server enhancements
Document the comprehensive Ruby/Solargraph improvements from PR #439:
- Automatic Rails project detection
- Ruby/Rails-specific exclude patterns for performance
- Enhanced error handling with Ruby manager support
- Improved LSP capability negotiation
- Better installation error messages
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
* Add Bundler support for Ruby projects
This change enhances the Solargraph language server implementation to properly support Ruby projects using Bundler with vendor/bundle configurations.
Key improvements:
- Detects Bundler projects by checking for Gemfile existence
- Supports both 'bin/bundle' and 'bundle' commands
- Checks Gemfile.lock for solargraph availability
- Uses 'bundle exec solargraph' when appropriate
- Provides clear error messages for missing solargraph in Bundler projects
- Maintains backward compatibility with non-Bundler projects
Fixes permission issues encountered with rbenv/system-managed Ruby installations
when trying to install gems globally.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Add timeout configuration for Solargraph language server
This change adds proper timeout handling to the Solargraph Ruby language server
to address initialization timeout issues, especially in Bundler environments.
Key improvements:
- Set 120-second request timeout for LSP requests and initialization
- Add 60-second server readiness timeout with graceful fallback
- Enhanced logging for timeout scenarios
- Better handling of slow initialization in large projects or Bundler environments
This resolves connection timeout issues where Solargraph takes longer than
the default 30-second MCP timeout to fully initialize and become ready.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* feat: Add comprehensive bash language support
Implement BashLanguageServer using bash-language-server (v5.4.0)
- Add automatic Node.js/npm dependency management
- Support .sh and .bash file extensions
- Include cross-platform compatibility (Windows .cmd handling)
- Add comprehensive test infrastructure with realistic bash scripts
- Integrate bash into Language enum and language server factory
- Add bash pytest marker for selective testing
- Include bash_language_server fixture for tests
Features:
* LSP capabilities: text sync, completion, hover, document symbols
* Runtime dependency installation via npm
* Symbol recognition for functions, variables, conditionals
* Proper LSP initialization and error handling
* Test repository with main.sh, utils.sh, and config.sh examples
Files:
+ src/solidlsp/language_servers/bash_language_server.py (new implementation)
+ test/solidlsp/bash/test_bash_basic.py (comprehensive test suite)
+ test/resources/repos/bash/test_repo/ (test scripts)
* src/solidlsp/ls_config.py (add BASH enum and file patterns)
* src/solidlsp/ls.py (integrate bash language server)
* pyproject.toml (add bash pytest marker)
* test/conftest.py (add bash_language_server fixture)
Tests: 2 passed, 7 appropriately skipped
All existing tests continue to pass (288 passed total)
* trigger flow
* feat: enhance bash function detection with hybrid LSP + regex approach
- Upgrade bash-language-server from 5.4.0 to 5.6.0 for better capabilities
- Add hybrid function detection: primary LSP + regex fallback when needed
- Implement _detect_bash_functions() with regex patterns for both syntax types:
* function name() { } (function keyword syntax)
* name() { } (regular function syntax)
- Add _find_function_end() with brace matching for accurate function boundaries
- Enhance request_document_symbols() with intelligent fallback logic
- Add comprehensive test suite with 4 new test functions:
* test_bash_function_detection_hybrid_approach
* test_bash_function_detection_with_body
* test_bash_regex_fallback_detection
* test_bash_function_syntax_patterns
- All tests passing: 6 passed, 7 skipped, 0 failed
- Maintains 100% backward compatibility
- Enables full symbolic operations for bash functions: find_symbol, replace_symbol_body, etc.
* remove trash
* clean: remove debug changes from Python services.py
- Remove 'MODIFIED VIA SYMBOLIC OPERATIONS!' debug comments
- Remove debug print statements added during testing
- Restore original clean docstring and code
- No functional changes to bash language support implementation
* fix: Remove non-bash specific directory ignoring from BashLanguageServer
- Removes is_ignored_dirname override that included generic directories like node_modules, .cache, tmp, temp
- These directories aren't bash-specific and gitignore already handles file exclusion
- Addresses PR feedback: 'that doesn't seem bash related. Note that gitignored files are ignored anyway'
* fix: Restructure bash tests to follow standard patterns and remove pytest.skip
- Replace custom bash_language_server fixture with standard parametrized language_server fixture
- Remove all pytest.skip statements and replace with proper assertions or failures
- Remove tests for non-existent methods (get_symbols_for_document, get_workspace_symbols, etc.)
- Keep only tests that use actual SolidLanguageServer methods like request_document_symbols
- All bash tests now pass successfully
- Addresses PR feedback about test structure and pytest.skip removal
* docs: Add bash language support to README
- Add Bash to the list of directly supported languages
- Note that it requires Node.js and npm for bash-language-server installation
- Addresses PR feedback about missing README extension for bash support
* docs: Add bash language support to CHANGELOG
- Document comprehensive bash language support with bash-language-server integration
- Highlight key features: .sh/.bash extensions, hybrid function detection, automatic dependency management
- Note cross-platform compatibility including Windows support
- Addresses PR feedback about missing CHANGELOG extension for bash support
* refactor: Change regex fallback to always-on hybrid detection for bash functions
- Remove conditional logic that only ran regex when LSP found no functions
- Implement always-on hybrid approach that runs both LSP and regex detection
- Add comprehensive documentation explaining bash-language-server limitations
- Add new _merge_function_detections method to combine results without duplicates
- Addresses reviewer feedback about files with mixed function notation styles
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
MischaPanch