mirror of
https://github.com/tiennm99/store-scraper-bot.git
synced 2026-10-11 12:29:01 +00:00
chore: journal Phase 7 cleanup of vercel-upstash consolidation
Closes the 260509-1656-consolidate-vercel-upstash plan with a record
of the cleanup commit (0a395bd) and the operator follow-ups left open.
This commit is contained in:
1 parent
f1710a5698
commit
c61b77f3c0
1 file changed
+83
@@ -0,0 +1,83 @@
|
||||
# Vercel + Upstash Consolidation: Phase 7 Cleanup Complete (0a395bd)
|
||||
|
||||
**Date**: 2026-05-09 21:50
|
||||
**Severity**: Low
|
||||
**Component**: Repository maintenance
|
||||
**Status**: Phase 7 complete; consolidation plan fully closed
|
||||
|
||||
## What Happened
|
||||
|
||||
Executed Phase 7 cleanup after operator confirmed Phase 6 deploy + cutover stable. Deleted Cloudflare Workers + Docker artifacts (19 files, -2137 lines net). Commit `0a395bd` removes tech debt from the consolidation migration.
|
||||
|
||||
**Deletions:**
|
||||
- `wrangler.toml`, `Dockerfile`, `docker-compose.yml`, `docker-compose.dev.yml`
|
||||
- `scripts/migrate-atlas-to-upstash.js` (one-shot migration confirmed done Phase 6)
|
||||
|
||||
**Modifications:**
|
||||
- `package.json`: dropped `wrangler`, `mongodb` devDeps; removed `migrate*` scripts; `npm install` regenerated lock (-70 packages)
|
||||
- `README.md`: rewritten for Vercel + Upstash; dropped Docker/Wrangler/Atlas migration sections
|
||||
- `.gitignore`, `.vercelignore`: pruned CF/Wrangler entries
|
||||
- `.env.deploy.example`: dropped `MONGODB_URI`
|
||||
- `src/{logger,models/*,repository}`: refreshed stale CF KV / Worker comments
|
||||
|
||||
**Verification:**
|
||||
- `npm run lint` (secret-leak check): clean
|
||||
- `node --check`: clean on modified files
|
||||
- `git grep cloudflare|wrangler|store_kv` outside `plans/journals`: 0 hits
|
||||
- Plan metadata updated; `plans/todo.md` migrated consolidation to completed section
|
||||
|
||||
## The Brutal Truth
|
||||
|
||||
This was the cleanup no one enjoys but everyone needs: scooping up tech debt that accumulated from multiple deployment strategies. No drama, no failures—just 2 hours of methodical deletion and documentation. Anticlimactic victory.
|
||||
|
||||
The real insight is that Phase 6→7 boundary forced confirmation of production stability before irreversible cleanup. Without that gate, a failed cutover would've meant manual resurrection of Docker / Wrangler config from git history. Not pleasant. Good process wins.
|
||||
|
||||
## Technical Details
|
||||
|
||||
**Lines removed:** 2137 (net -66 after new text added)
|
||||
**Files deleted:** 5 core + 14 package-lock.json lines
|
||||
**Dependencies removed:** `wrangler`, `mongodb` (with their transitive trees)
|
||||
**Architecture surface area reduced:** Vercel-only compute + Upstash-only caching (no hybrid paths)
|
||||
|
||||
Key structural win: no lingering "support local Docker" branches in setup docs or scripts—forces all new developers toward REST-based dev path (`vercel dev` + Upstash dashboard) rather than spinning up local Mongo containers.
|
||||
|
||||
## What We Tried
|
||||
|
||||
1. **Grepped for CF/Wrangler/Docker references:** Found 5 comment lines in models + logger + repository. Refreshed all.
|
||||
2. **Validated .gitignore cleanup:** Removed entries for non-existent Dockerfile + docker-compose; kept only Vercel-relevant ignores.
|
||||
3. **Tested package-lock.json regeneration:** `npm install` succeeded; shrinkwrap locked on Node 20 LTS runtime.
|
||||
|
||||
## Root Cause Analysis
|
||||
|
||||
**Why this phase existed:**
|
||||
- Phase 6 required cutover with dual-path support (old Docker + new Vercel) for rollback insurance.
|
||||
- Phase 7 removes fallback once 7-day stability threshold crossed (operator-confirmed).
|
||||
- Pattern: migration safety first, cleanup second.
|
||||
|
||||
**Why consolidation was needed:**
|
||||
- Original architecture: Cloudflare Workers (compute) + KV (cache) + Atlas (data source)
|
||||
- Phases 1-5 replaced Workers → Vercel, KV → Upstash, added scraper inlining
|
||||
- Phase 7 removes the old plumbing that was no longer being used post-cutover
|
||||
|
||||
## Lessons Learned
|
||||
|
||||
1. **Gates between migration phases prevent catastrophic cleanup.** Temptation to delete immediately after deploy is real; 7-day gate saved potential rollback path if Phase 6 cutover had hiccups.
|
||||
|
||||
2. **Comments accumulate faster than code in multi-phase rewrites.** Found 5 stale CF references in comments alone—automated grep + replace beats manual scanning.
|
||||
|
||||
3. **Package-lock.json churn is noisy but necessary.** Removing 70 packages creates large diff. Acceptable trade-off for reduced supply-chain surface area (fewer `npm audit` issues, faster `npm ci` on CI/CD).
|
||||
|
||||
4. **Docker cleanup is rarely reversible cheaply.** Once Dockerfile + docker-compose deleted, anyone joining project must accept REST-based dev. Document this transition in README decisively.
|
||||
|
||||
## Next Steps
|
||||
|
||||
**Handed off to operator (external-only, out of scope for this repo):**
|
||||
1. Archive / deprecate `tiennm99/store-scraper` repo (old scraper wrapper on GitHub)
|
||||
2. Delete old `store-scraper` Vercel project on dashboard (if it exists separate from `store-scraper-bot`)
|
||||
3. Optionally clean up Cloudflare dashboard (delete Worker + STORE_KV namespace) — only if CF resources were ever provisioned; likely N/A
|
||||
|
||||
**No further code work needed.** Plan completely closed; all 7 phases shipped.
|
||||
|
||||
---
|
||||
|
||||
**Status:** Phase 7 complete. Consolidation plan fully closed. Repository now Vercel + Upstash only, no legacy multi-platform code paths.
|
||||
Reference in new issue
Block a user