Intelephense: Account for spaces in launch command (use robust list syntax instead of string)

This commit is contained in:
Dominik Jain authored and Dominik Jain committed 2025-10-16 22:35:50 +02:00
1 parent b1d9ac5765
commit 5d7aeb680f
1 file changed
+3 -5
@@ -39,9 +39,7 @@ class Intelephense(SolidLanguageServer):
return super().is_ignored_dirname(dirname) or dirname in ["node_modules", "vendor", "cache"]
@classmethod
def _setup_runtime_dependencies(
cls, logger: LanguageServerLogger, config: LanguageServerConfig, solidlsp_settings: SolidLSPSettings
) -> str:
def _setup_runtime_dependencies(cls, logger: LanguageServerLogger, solidlsp_settings: SolidLSPSettings) -> list[str]:
"""
Setup runtime dependencies for Intelephense and return the command to start the server.
"""
@@ -84,13 +82,13 @@ class Intelephense(SolidLanguageServer):
intelephense_executable_path
), f"intelephense executable not found at {intelephense_executable_path}, something went wrong."
return f"{intelephense_executable_path} --stdio"
return [intelephense_executable_path, "--stdio"]
def __init__(
self, config: LanguageServerConfig, logger: LanguageServerLogger, repository_root_path: str, solidlsp_settings: SolidLSPSettings
):
# Setup runtime dependencies before initializing
intelephense_cmd = self._setup_runtime_dependencies(logger, config, solidlsp_settings)
intelephense_cmd = self._setup_runtime_dependencies(logger, solidlsp_settings)
super().__init__(
config,